fix: Ignore tempoary pyc.NNN files in wheels by rickeylev · Pull Request #1266 · bazel-contrib/rules_python

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev · 2023-06-13T19:03:00Z

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named *.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.

Fixes#1261

We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixesbazel-contrib#1261

chrislovecnm

LGTM

Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazel-contrib#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixesbazel-contrib#1261 Work towards bazel-contrib#1520

…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes#1261 Work towards #1520

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

rickeylev requested a review from chrislovecnm June 13, 2023 19:03

rickeylev requested review from f0rmiga and hrfuller as code owners June 13, 2023 19:03

chrislovecnm approved these changes Jun 13, 2023
View reviewed changes

chrislovecnm enabled auto-merge June 13, 2023 19:04

chrislovecnm added this pull request to the merge queue Jun 13, 2023

Merged via the queue into bazel-contrib:main with commit 68db955Jun 13, 2023

rickeylev deleted the fix.ignore.pycn.files branch June 21, 2023 06:20

rickeylev mentioned this pull request Nov 6, 2023
fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541
Merged

Uh oh!

Uh oh!

Conversation

rickeylev commented Jun 13, 2023

Uh oh!

chrislovecnm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rickeylev commented Jun 13, 2023

Uh oh!

chrislovecnm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rickeylev commented Jun 13, 2023

Uh oh!

chrislovecnm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rickeylev commented Jun 13, 2023

Uh oh!

chrislovecnm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rickeylev commented Jun 13, 2023

Uh oh!

chrislovecnm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants