Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); docs: Update gazelle/README.md to fix `package_name` formatting by michael-christen · Pull Request #1712 · bazel-contrib/rules_python · GitHub
Skip to content

docs: Update gazelle/README.md to fix package_name formatting - #1712

Merged
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1
Jan 22, 2024
Merged

docs: Update gazelle/README.md to fix package_name formatting#1712
aignas merged 1 commit into
bazel-contrib:mainfrom
michael-christen:patch-1

Conversation

@michael-christen

Copy link
Copy Markdown
Contributor

Latex output was shown, should just be escaped

image

latex output was shown, should just be escaped
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@michael-christenmichael-christen changed the title docs: Update README.mddocs: Update gazelle/README.md to fix package_name formattingJan 21, 2024
@aignas

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Could you please sign the CLA?

@michael-christen

Copy link
Copy Markdown
ContributorAuthor

Of course, signed and updated!

Looks like there's an unrelated failure at "examples/multi_python_versions: Windows, workspace on :windows: (OpenJDK 11, VS2022)", anything I should do about that?

michael-christen added a commit to michael-christen/toolbox that referenced this pull request Jan 22, 2024
Changes:
- Establish a mechanism for defining external python requirements via a
`requirements.in`, generating updates to a lock file with `bazel run
//:requirements.update`
- Configure gazelle python and protobufs
- Configures via gazelle directives to use a file based approach, stick
with the BUILD configuration, disable go, default visibility to private
and resolve py imports
- Update dev_setup to install openjdk (java), tree, ranger, ag
New Commands:
```
bazel run //:requirements.update
bazel run //:gazelle_python_manifest.update
bazel run //:gazelle
```
New Tests:
```
//:requirements_test
//::gazelle_python_manifest.test
```
Notes:
- One of the recurring issues I have every time I deal with updating
WORKSPACE is slight incompatibilities with various repos that result in
incomprehensible output errors.
- stackb/rules_proto is one of the only things that seems to support
what I'm looking for, and while it is getting steady contributions
hasn't pubilshed a release in about a year.
https://github.com/rules-proto-grpc/rules_proto_grpc. Additionally, it
could be handy to look into what it would take to make my own "shitty"
version of these rules to learn more about what's going on in gazelle's
/ bazel's internals
- bzlmod migration didn't go well for me, most tutorials out there still
use WORKSPACE, might be good to look into in the future / figure out how
to migrate piecemeal, but bypassed this and 7.0.1 bazel upgrade for now
Related Issues:
- Noting the issue with requiring a gazelle directive for proto
libraries: bazel-contrib/rules_python#1703
- bazel-contrib/rules_python#1664 fixes the reason
I had to "disable" my py_binary, wait for that to release and then
update. I could probably patch this in, but don't quite know how 🤷
- Sounds like there's some talk around gazelle c++
bazel-contrib/bazel-gazelle#910
- I'm helping ;) bazel-contrib/rules_python#1712
(doc update)
References:
- https://github.com/bazelbuild/bazel-gazelle
- https://github.com/stackb/rules_proto
- https://github.com/bazelbuild/rules_python/tree/main/gazelle
Future Things to Look Into:
- Setup a gazelle test that checks output of `//:gazelle -- -mode diff`
is zero
- Configure rust with gazelle: https://github.com/Calsign/gazelle_rust
- A really cool / general parser / generator (what github uses for
"semantic" tool): https://tree-sitter.github.io/tree-sitter/ Could use
to make small code generator / modification? Or maybe more general
utilities?
- General compile command completion:
https://github.com/hedronvision/bazel-compile-commands-extractor
- Maybe play with https://github.com/rules-proto-grpc/rules_proto_grpc
as an alternative to stackb
- If I can't use gazelle for some things, mess around with
https://github.com/bazelbuild/buildtools/tree/master/buildozer
@aignas
aignas enabled auto-merge January 22, 2024 08:02
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@aignas
aignas added this pull request to the merge queueJan 22, 2024
Merged via the queue into bazel-contrib:main with commit 2b231bbJan 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-christen@aignas