Uh oh!
There was an error while loading. Please reload this page.
refactor: Mark internal and python extension as reproducible - #1892
Merged
Conversation
This avoids an unnecessary lockfile entry for users of rules_python.
fmeum
commented
May 12, 2024
MemberAuthor
@aignas Could you review this? |
aignas
reviewed
May 13, 2024
aignas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM in general, would love a line in CHANGELOG about the bumped dependency.
It does mean that the rules_python_gazelle_plugin will always have a warning because it depends on 1.3, so maybe we should bump the gazelle/MODULE.bazel as well?
Uh oh!
There was an error while loading. Please reload this page.
python extension as reproducibleMemberAuthor
I also marked the |
aignas
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary lockfile entries for users of rules_python.