') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: make coverage work with bootstrap=script by rickeylev · Pull Request #2574 · bazel-contrib/rules_python · GitHub
Skip to content

fix: make coverage work with bootstrap=script - #2574

Merged
aignas merged 4 commits into
bazel-contrib:mainfrom
rickeylev:fix.bootstrap.coverage
Jan 23, 2025
Merged

fix: make coverage work with bootstrap=script#2574
aignas merged 4 commits into
bazel-contrib:mainfrom
rickeylev:fix.bootstrap.coverage

Conversation

@rickeylev

@rickeylevrickeylev commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

The script based bootstrap wasn't expanding the coverage template variable, which prevented
coverage from activating. This was introduced when it was switched to the venv layout.

To fix, expand the %coverage_tool% template variable as done elsewhere.

Tested manually, per repro instructions in #2572. While I did devise a way to mostly
test this without an integration test, it was thwarted by some other bugs.

Along the way, improve some of the bootstrap debug output and fix a comment.

Fixes#2572

@aignas
aignas added this pull request to the merge queueJan 23, 2025
Merged via the queue into bazel-contrib:main with commit ea716feJan 23, 2025
@rickeylev
rickeylev deleted the fix.bootstrap.coverage branch January 24, 2025 17:10
ewianda pushed a commit to ewianda/rules_python that referenced this pull request Jan 25, 2025
@rickeylev@ewianda
fix: make coverage work with bootstrap=script (bazel-contrib#2574)
3562b75
The script based bootstrap wasn't expanding the coverage template
variable, which prevented
coverage from activating. This was introduced when it was switched to
the venv layout.
To fix, expand the `%coverage_tool%` template variable as done
elsewhere.
Tested manually, per repro instructions in bazel-contrib#2572. While I did devise a
way to mostly
test this without an integration test, it was thwarted by some other
bugs.
Along the way, improve some of the bootstrap debug output and fix a
comment.
Fixesbazel-contrib#2572
ewianda pushed a commit to ewianda/rules_python that referenced this pull request Jan 25, 2025
@rickeylev@ewianda
fix: make coverage work with bootstrap=script (bazel-contrib#2574)
7d4f6e8
The script based bootstrap wasn't expanding the coverage template
variable, which prevented
coverage from activating. This was introduced when it was switched to
the venv layout.
To fix, expand the `%coverage_tool%` template variable as done
elsewhere.
Tested manually, per repro instructions in bazel-contrib#2572. While I did devise a
way to mostly
test this without an integration test, it was thwarted by some other
bugs.
Along the way, improve some of the bootstrap debug output and fix a
comment.
Fixesbazel-contrib#2572
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aignasaignasaignas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Coverage Report Shows no valid records found with bootstrap_impl=script

2 participants

@rickeylev@aignas