Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 717
feat: env-var for additional interpreter args in bootstrap stage 1#2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rickeylev
merged 7 commits into
bazel-contrib:main
from
andponlin-canva:bootstrp-additional-interp-argsMar 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
827d77b
feat: env-var for additional interpreter args in bootstrap
andponlin-canva 9aa5eb6
feat: env-var for additional interpreter args in bootstrap - add unse…
andponlin-canva 14c2bfc
feat: env-var for additional interpreter args in bootstrap stage 1 --…
andponlin-canva d7ecc3b
feat: env-var for additional interpreter args in bootstrap stage 1 --…
andponlin-canva c02f3d8
Merge branch 'main' into bootstrp-additional-interp-args
aignas 6026846
add docs to cross ref interpreter_args and env var
rickeylev df484a1
xref changelog
rickeylev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -202,6 +202,7 @@ stage2_bootstrap="$RUNFILES_DIR/$STAGE2_BOOTSTRAP" | ||
| declare -a interpreter_env | ||
| declare -a interpreter_args | ||
| declare -a additional_interpreter_args | ||
| # Don't prepend a potentially unsafe path to sys.path | ||
| # See: https://docs.python.org/3.11/using/cmdline.html#envvar-PYTHONSAFEPATH | ||
| @@ -220,6 +221,12 @@ if [[ "$IS_ZIPFILE" == "1" ]]; then | ||
| interpreter_args+=("-XRULES_PYTHON_ZIP_DIR=$zip_dir") | ||
| fi | ||
| if [[ -n "${RULES_PYTHON_ADDITIONAL_INTERPRETER_ARGS}" ]]; then | ||
| read -a additional_interpreter_args <<< "${RULES_PYTHON_ADDITIONAL_INTERPRETER_ARGS}" | ||
andponlin-canva marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| interpreter_args+=("${additional_interpreter_args[@]}") | ||
| unset RULES_PYTHON_ADDITIONAL_INTERPRETER_ARGS | ||
| fi | ||
| export RUNFILES_DIR | ||
| command=( | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.