feat(rules): add main_module attribute to run a module name (python -m) by rickeylev · Pull Request #2671 · bazel-contrib/rules_python

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

rickeylev · 2025-03-17T04:18:00Z

This implements the ability to run a module name instead of a file path, aka
python -m style of invocation.

This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.

As a side effect, the srcs attribute is no longer required.

Fixes#2539

aignas · 2025-03-17T07:10:06Z

+This is mutually exclusive with {obj}`main_module`.
+""",
+ ),
+ "main_module": lambda: attrb.String(


nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.

I'd rather not because it's not clear how to transform the file name into a module name.

groodt

LGTM

🎉

groodt · 2025-03-18T01:18:51Z

Im looking forward to trying:
main_module = "pytest.main",

Or even better:
main_module = "pytest_bazel.main",

wip: adding main_module attr
3f312e5

rickeylev requested a review from aignas as a code owner March 17, 2025 04:18

aignas approved these changes Mar 17, 2025
View reviewed changes

groodt approved these changes Mar 18, 2025
View reviewed changes

rickeylev added this pull request to the merge queue Mar 19, 2025

Merged via the queue into bazel-contrib:main with commit 032f6aaMar 19, 2025

rickeylev deleted the feat.main.module branch April 5, 2025 16:36

groodt mentioned this pull request Apr 9, 2025
feat: Add support for REPLs #2723
Merged

aignas mentioned this pull request Apr 10, 2025
Support src-less invocation of py_binary #2765
Closed

brandonchinn178 mentioned this pull request Jul 9, 2025
feat: Support main_module with bootstrap_impl=system_python #3072
Open