Uh oh!
There was an error while loading. Please reload this page.
refactor(toolchains): better sha256 printing helper - #3028
Merged
Conversation
Before this PR the toolchain sha256 values would be printed in a way that would require further text manipulation. Now we print the values that need to be just copy pasted.
aignasforce-pushed
the
chore/rm-old-toolchains
branch
from
July 4, 2025 04:36
ba3d5f3 to
a92fea4Compareaignas
marked this pull request as ready for review
July 4, 2025 05:03
aignas
enabled auto-merge
July 4, 2025 05:04
rickeylev
approved these changes
Jul 6, 2025
aignas added a commit
to aignas/rules_python
that referenced
this pull request
Jul 8, 2025
It seems that in bazel-contrib#3062 we did not notice that the latest builds for `linux-aarch64-freethreaded` actually needed a different build tag and this is the case only for the latest releases. What is more, the `windows-aarch64` build had a wrong strip-prefix. This is fixing all of these issues. bazel-contrib#3028 will make the 404 error messages from `curl` more visible, so the first issue will be more easily caught during authoring, whereas the second issue is going to be more likely caught via code review, or a CI that is exercising the actual toolchains.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jul 8, 2025
It seems that in #3062 we did not notice that the latest builds for `linux-aarch64-freethreaded` actually needed a different build tag and this is the case only for the latest releases. What is more, the `windows-aarch64` build had a wrong strip-prefix. This is fixing all of these issues. #3028 will make the 404 error messages from `curl` more visible, so the first issue will be more easily caught during authoring, whereas the second issue is going to be more likely caught via code review, or a CI that is exercising the actual toolchains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR the toolchain sha256 values would be printed in a way
that would require further text manipulation. Now we print the values
that need to be just copy pasted.
Whilst at it simplify the
curlcommand to remove the conditional.Testing done:
Work towards #2704