') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ci: use Ubuntu 22.04 by aignas · Pull Request #3083 · bazel-contrib/rules_python · GitHub
Skip to content

ci: use Ubuntu 22.04 - #3083

Merged
aignas merged 8 commits into
mainfrom
ci.bump.ubuntu.rbe
Jul 14, 2025
Merged

ci: use Ubuntu 22.04#3083
aignas merged 8 commits into
mainfrom
ci.bump.ubuntu.rbe

Conversation

@aignas

@aignasaignas commented Jul 13, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Update the CI configuration and start testing on Ubuntu 22.04.

Fixes#3084

@aignas

aignas commented Jul 13, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Hi, @meteorcloudy, do you know why the RBE CI started failing over the past week? The first guess was that it was because Ubuntu 2004 is too old, but just bumping it does not solve the failure.

@aignasaignas mentioned this pull request Jul 13, 2025
Closed
@meteorcloudy

meteorcloudy commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

We did update the rbe config last week, but not sure if the compile error is caused by that:

In file included from external/abseil-cpp~/absl/hash/internal/hash.cc:15:0:
external/abseil-cpp~/absl/hash/internal/hash.h:66:10: fatal error: filesystem: No such file or directory
#include <filesystem> // NOLINT
^~~~~~~~~~~~

Are you able to reproduce the same issue with the gcr.io/bazel-public/ubuntu2404 docker image?

/cc @coeuvre

@meteorcloudy

meteorcloudy commented Jul 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I see, you probably need to update the docker container used for the RBE workers, which is currently ubuntu1804 with a probably very old gcc version

See

rules_python/python/private/internal_dev_deps.bzl

Line 29 in 5c68ff9

toolchain="ubuntu1804-bazel-java11",

Update to ubuntu2204 could probably work

@aignas
aignas marked this pull request as ready for review July 14, 2025 13:09
@aignas
aignas requested a review from rickeylev as a code ownerJuly 14, 2025 13:09
@aignas
aignas enabled auto-merge July 14, 2025 13:09
@aignas
aignas added this pull request to the merge queueJul 14, 2025
Merged via the queue into main with commit c30980aJul 14, 2025
@krasimirggkrasimirgg mentioned this pull request Jul 15, 2025
Merged
github-merge-queueBot pushed a commit to bazelbuild/rules_rust that referenced this pull request Jul 15, 2025
@krasimirgg
update RBE workers platform toubuntu2204(#3506)
81b4220
Try to fix the RBE errors like:
```
external/abseil-cpp+/absl/hash/internal/hash.h:66:10: fatal error: filesystem: No such file or directory
```
Followed the fix for python
bazel-contrib/rules_python#3083.
@aignas
aignas deleted the ci.bump.ubuntu.rbe branch August 18, 2025 12:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RBE Failures related to protobuf, abseil-cpp, and #include <filesystem>

3 participants

@aignas@meteorcloudy@rickeylev