Skip to content

docs: Fix GitHub PR links - #3346

Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom
thejcannon:patch-1
Oct 15, 2025
Merged

docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom
thejcannon:patch-1

Conversation

@thejcannon

@thejcannonthejcannon commented Oct 13, 2025•
edited by rickeylev
Loading

Copy link
Copy Markdown
Contributor

Fix the gh-pr special markup to use the right URL.

It was using /pulls/ which is a search, when it should be /pull/

@gemini-code-assist

gemini-code-assistBot commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.

Highlights

  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assistBot reviewed Oct 13, 2025
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.

@rickeylevrickeylev changed the title type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev approved these changes Oct 13, 2025
View reviewed changes

@rickeylevrickeylev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rickeylev
rickeylev added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@aignas
aignas added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@aignas
aignas added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@rickeylev
rickeylev added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@rickeylev
rickeylev added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@rickeylev
rickeylev merged commit 587f6e9 into bazel-contrib:mainOct 15, 2025
4 checks passed
@thejcannon
thejcannon deleted the patch-1 branch October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
docs: Fix GitHub PR links by thejcannon · Pull Request #3346 · bazel-contrib/rules_python · GitHub
Skip to content
docs: Fix GitHub PR links - #3346
Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Oct 15, 2025
Merged
docs: Fix GitHub PR links#3346
rickeylev merged 1 commit into
bazel-contrib:mainfrom 
thejcannon:patch-1
Conversation
@thejcannon
@thejcannonthejcannon
commented
Oct 13, 2025•

edited by rickeylev

Loading

Copy link


Copy Markdown

Contributor
Fix the gh-pr special markup to use the right URL.
It was using /pulls/ which is a search, when it should be /pull/
@gemini-code-assist
gemini-code-assistBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @thejcannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important issue in the project's documentation configuration. It updates the URL pattern used for generating links to GitHub Pull Requests, ensuring that all such links correctly navigate to the intended PR pages rather than a search results page. This improves the usability and accuracy of the documentation.
Highlights
  • Documentation Link Fix: Corrected an incorrect URL format for GitHub Pull Request links within the documentation configuration, changing /pulls/ to /pull/.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Oct 13, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request addresses an issue with incorrect GitHub PR link generation in the documentation. The change correctly updates the URL path from /pulls/ to /pull/ in the Sphinx configuration. This is a simple and effective fix. The change is correct and I have no further feedback.
@rickeylevrickeylev
changed the title
type(docs): Fix GitHub PR linksdocs: Fix GitHub PR linksOct 13, 2025
rickeylev
rickeylev
approved these changes
Oct 13, 2025
View reviewed changes
@rickeylevrickeylev
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@aignas
aignas
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
added this pull request to the merge queueOct 14, 2025
@github-merge-queue
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2025
@rickeylev
rickeylev
merged commit 587f6e9
into
bazel-contrib:mainOct 15, 2025

4 checks passed

@thejcannon
thejcannon
deleted the

patch-1

branch
October 15, 2025 10:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aignasaignasaignas approved these changes
@rickeylevrickeylevrickeylev approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thejcannon@aignas@rickeylev