test(whl_library): test a recent fix for pipstar - #3469

Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom
aignas:fix.pipstar.extras
Jan 12, 2026
Merged

test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom
aignas:fix.pipstar.extras

Conversation

@aignas

@aignasaignas commented Dec 18, 2025

Copy link
Copy Markdown
Collaborator

Test for fix for #3352 implemented in #3468.

@gemini-code-assist

gemini-code-assistBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.

Highlights

  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assistBot reviewed Dec 18, 2025
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.

aignas
aignas commented Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl Outdated
# also enable pipstar for any whls that are downloaded without `pip`
enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load

@aignasaignasDec 18, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.

@aignas

aignas commented Dec 18, 2025

Copy link
Copy Markdown
CollaboratorAuthor

I have no idea why it is failing... :/

@rickeylev

rickeylev commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.

There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using

@rickeylev

rickeylev commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

Woot, tests passed

@rickeylev
rickeylev added this pull request to the merge queueJan 12, 2026
Merged via the queue into bazel-contrib:main with commit 42085b5Jan 12, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(whl_library): test a recent fix for pipstar - #3469
Merged
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Jan 12, 2026
Merged
test(whl_library): test a recent fix for pipstar#3469
rickeylev merged 7 commits into
bazel-contrib:mainfrom 
aignas:fix.pipstar.extras
Conversation
@aignas
@aignasaignas
commented
Dec 18, 2025

Copy link


Copy Markdown

Collaborator
Test for fix for #3352 implemented in #3468.
@gemini-code-assist
gemini-code-assistBot
commented
Dec 18, 2025

Copy link


Copy Markdown

Contributor
Summary of Changes
Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.
Highlights
  • New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
  • Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
  • Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Dec 18, 2025
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.
aignas
aignas
commented
Dec 18, 2025
View reviewed changes
Comment threadpython/private/pypi/whl_library.bzl
Outdated

 # also enable pipstar for any whls that are downloaded without `pip`
 enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
 enable_pipstar_extract = (rp_config.enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
 enable_pipstar_extract = (enable_pipstar and rp_config.bazel_8_or_later) and rctx.attr.config_load
@aignasaignasDec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting me extract without python.
@aignas
aignas
commented
Dec 18, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I have no idea why it is failing... :/
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
The CI error is saying the repo is undefined. I think it's just that we never setup workspace builds with the whl_from_dir stuff. internal_dev_deps is a bzlmod-only file, and all the tests using the repos it defines are tagged as bzlmod only.
There's a SUPPORTS_BZLMOD_UNIXY helper that tests are using
@rickeylev
rickeylev
commented
Jan 12, 2026

Copy link


Copy Markdown

Collaborator
Woot, tests passed
@rickeylev
rickeylev
added this pull request to the merge queueJan 12, 2026

Merged
via the queue into
bazel-contrib:main
with commit 42085b5Jan 12, 2026

4 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickeylevrickeylevrickeylev approved these changes
@groodtgroodtAwaiting requested review from groodt

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aignas@rickeylev