Skip to content

ci: update RBE toolchain version from ubuntu2204 to ubuntu2404 - #3778

Merged
meteorcloudy merged 3 commits into
mainfrom
meteorcloudy-patch-2
May 19, 2026
Merged

ci: update RBE toolchain version from ubuntu2204 to ubuntu2404#3778
meteorcloudy merged 3 commits into
mainfrom
meteorcloudy-patch-2

Conversation

@meteorcloudy

@meteorcloudymeteorcloudy commented May 15, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RBE toolchain version from Ubuntu 22.04 to 24.04 in python/private/internal_dev_deps.bzl. Feedback indicates that the WORKSPACE file should also be updated to maintain consistency and prevent CI failures for WORKSPACE-based builds.

Comment threadpython/private/internal_dev_deps.bzl
@meteorcloudy

Copy link
Copy Markdown
ContributorAuthor

Hmm, actually ubuntu2204 should still be supported. There might be some infra breakages caused by https://github.com/bazelbuild/continuous-integration/pull/2617/changes

/cc @coeuvre

@coeuvre

Copy link
Copy Markdown

I have regenerated toolchain for ubuntu2204.

@meteorcloudy

Copy link
Copy Markdown
ContributorAuthor

Upgrading rules_cc fixed the RBE build

@meteorcloudy
meteorcloudy enabled auto-merge May 19, 2026 12:27
@aignasaignas changed the title Update RBE toolchain version from ubuntu2204 to ubuntu2404ci: update RBE toolchain version from ubuntu2204 to ubuntu2404May 19, 2026
@meteorcloudy
meteorcloudy added this pull request to the merge queueMay 19, 2026
Merged via the queue into main with commit 32527deMay 19, 2026
8 checks passed
@meteorcloudy
meteorcloudy deleted the meteorcloudy-patch-2 branch May 19, 2026 14:24
aignas pushed a commit that referenced this pull request May 20, 2026
aignas pushed a commit that referenced this pull request May 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@meteorcloudy@coeuvre@aignas