Skip to content

chore(release): process backports as part of creating RC - #3896

Merged
rickeylev merged 3 commits into
bazel-contrib:mainfrom
rickeylev:process-backports-before-rc
Jul 3, 2026
Merged

chore(release): process backports as part of creating RC#3896
rickeylev merged 3 commits into
bazel-contrib:mainfrom
rickeylev:process-backports-before-rc

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

Automatically process pending backports when /create-rc is called.

If any backport fails to process (e.g. due to cherry-pick conflicts), the RC creation will abort.
Additionally, support --triggering-comment option to react with a thumbs-down emoji on the triggering comment if the command fails.

  • Call ProcessBackports in CreateRc before proceeding with RC tagging.
  • Refactor CreateRc.run to handle exceptions and reactions.
  • Update GitHub Actions workflows to pass comment_id to release_create_rc workflow.
  • Add unit tests for the new integration and reaction behavior.

- Call ProcessBackports in CreateRc before creating RC.
- Add --triggering-comment option to create-rc to react with thumbs-down on failure.
- Pass triggering comment from GHA workflows.
- Update tests and documentation.
@rickeylev
rickeylev requested a review from aignas as a code ownerJuly 3, 2026 15:33

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the /create-rc command to automatically process pending backports before creating a release candidate. If any backport fails, the process aborts, and if triggered by a comment, it reacts with a thumbs-down emoji. The changes include updates to the documentation, a new changelog entry, the core implementation in create_rc.py, and comprehensive unit tests. The review feedback suggests two improvements: using getattr to safely access args.triggering_comment to prevent potential AttributeErrors in tests or custom namespaces, and printing the full traceback when catching unexpected exceptions to facilitate debugging in CI/CD environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment threadtools/private/release/create_rc.py
Comment threadtools/private/release/create_rc.py
@rickeylevrickeylev changed the title feat(release): process backports before creating RCchore(release): process backports before creating RCJul 3, 2026
@rickeylevrickeylev changed the title chore(release): process backports before creating RCchore(release): process backports as part of creating RCJul 3, 2026
@rickeylev
rickeylev merged commit f1db067 into bazel-contrib:mainJul 3, 2026
8 of 10 checks passed
@rickeylev
rickeylev deleted the process-backports-before-rc branch July 3, 2026 16:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rickeylev