Uh oh!
There was an error while loading. Please reload this page.
refactor(pypi): add whl_deps_library repo rule - #3960
Merged
rickeylev merged 15 commits intoAug 1, 2026
Merged
Conversation
Summary: - Add a new repo rule to just read metadata.json - Add integration tests for the repository rules in `whl_library.bzl` file. - Make some of the arguments optional in the BUILD.bazel code generation. Split out of bazel-contrib#3856 Work towards bazel-contrib#2948
Contributor
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
aignas
commented
Jul 27, 2026
CollaboratorAuthor
Ran out of time working on this, feel free to hose this with AI tokens if desired. |
aignas
marked this pull request as ready for review
July 27, 2026 13:50
Contributor
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
… tests To prevent test failures across Bazel 7, 8, and 9 where Bzlmod canonical repository prefixes vary, dynamically parse canonical repository strings by splitting on '~' and '+'. Also filter out version-dependent toolchain type targets from dependency comparisons.
…_library_srcs_deps_switch
aignas
commented
Aug 1, 2026
CollaboratorAuthor
OK, please take a look. |
rickeylev
approved these changes
Aug 1, 2026
rickeylev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I renamed this to refactor(pypi). I'm pretty sure this is just an internal refactoring. I don't see any public APIs added or changed.
Uh oh!
There was an error while loading. Please reload this page.
rickeylev pushed a commit
to rickeylev/rules_python
that referenced
this pull request
Aug 1, 2026
…ntrib#3979) This adds a test to verify that bazel files are excluded from the files matched from an extracted wheel. Followup to bazel-contrib#3960 Work towards bazel-contrib#2948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
whl_library.bzlfile.
generation.
No changelog, because the rule is not yet exposed to the user in any way.
Split out of #3856
Work towards #2948
Fixes#3071