Uh oh!
There was an error while loading. Please reload this page.
refactor: ci with multiple tasks - #855
Merged
Merged
Conversation
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
requested review from
brandjon, lberki and thundergolfer
as code ownersOctober 12, 2022 06:05
f0rmiga
requested review from
alexeagle, groodt and hrfuller
and removed request for
brandjon, lberki and thundergolferOctober 12, 2022 06:05
Uh oh!
There was an error while loading. Please reload this page.
| working_directory: examples/build_file_generation | ||
| platform: windows | ||
| integration_test_bzlmod_linux: |
Contributor
There was a problem hiding this comment.
could you use https://github.com/bazelbuild/continuous-integration/blob/5a1a944d644bac905da8cab4111b14b6497b7316/buildkite/README.md#matrix-testing here to reduce the repetition?
MemberAuthor
There was a problem hiding this comment.
I didn't use it because I knew some wouldn't work on Windows. I fixed most of them, but there's still one test that needs fixing, then we can move to a matrix.
MemberAuthor
There was a problem hiding this comment.
Actually, with a78d426, 2 tests that need fixing for Windows.
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
alexeagle
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor CI to run examples as integration tests as separate tasks. This makes CI faster and improves the iteration experience when developing features multi-platform.