feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966

Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom
aignas:gazelle-bzlmod-1
Closed

feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom
aignas:gazelle-bzlmod-1

Conversation

@aignas

@aignasaignas commented Jan 3, 2023

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.

Issue number: #965

What is the new behavior?

We change the labels to point to the aliases that are present when bzlmod is used.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@aignasaignas mentioned this pull request Jan 3, 2023
Closed
12 tasks
@aignasaignas changed the title feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas mentioned this pull request Jan 11, 2023
Closed
alexeagle
alexeagle reviewed Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel Outdated
deps = [
requirement("pylint"),
# You can reference libraries using plain text form or the 'requirement' macro
"@pip//:pylint_pkg",

@alexeaglealexeagleJan 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.
(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)

@aignasaignasJan 18, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?

@aignasaignasJan 27, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?

alexeagle
alexeagle reviewed Jan 11, 2023
View reviewed changes

@alexeaglealexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?

That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7

@groodt

groodt commented Jan 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What if gazelle was changed to use the requirement function?

That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7

I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.

@aignas

aignas commented Jan 18, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@groodt, should we wait for the #989 to be done before we think about this again?

I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?

@aignasaignas mentioned this pull request Jan 27, 2023
Closed
12 tasks
aignasand others added 2 commits January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas changed the title feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas

aignas commented Feb 13, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.

@aignasaignas closed this Feb 13, 2023
@aignas
aignas deleted the gazelle-bzlmod-1 branch February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays - #966
Closed
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Closed
feat(pip_parse)!: use user friendly aliases to pip repos in requirements arrays#966
aignas wants to merge 4 commits into
bazel-contrib:mainfrom 
aignas:gazelle-bzlmod-1
Conversation
@aignas
@aignasaignas
commented
Jan 3, 2023

Copy link


Copy Markdown

Collaborator
PR Checklist
Please check if your PR fulfills the following requirements:
  •  Tests for the changes have been added (for bug fixes / features)
  •  Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
  •  Bugfix
  •  Feature (please, look at the "Scope of the project" section in the README.md file)
  •  Code style update (formatting, local variables)
  •  Refactoring (no functional changes, no api changes)
  •  Build related changes
  •  CI related changes
  •  Documentation content changes
  •  Other... Please describe:
What is the current behavior?
Currently the labels in the all_requirements and all_whl_requirements are not useable, which is needed for gazelle bzlmod support.
Issue number: #965
What is the new behavior?
We change the labels to point to the aliases that are present when bzlmod is used.
Does this PR introduce a breaking change?
  •  Yes
  •  No
Other information
@aignasaignas
mentioned this pull request
Jan 3, 2023
 Closed

12 tasks
@aignasaignas
changed the title
feat: Store alias labels in requirements arrays if using bzlmodfeat(pip_parse): Store alias labels in requirements arrays if using bzlmodJan 3, 2023
@aignasaignas
mentioned this pull request
Jan 11, 2023

Closed

alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
Comment threadexamples/bzlmod/BUILD.bazel
Outdated

 deps = [
 requirement("pylint"),
 # You can reference libraries using plain text form or the 'requirement' macro
 "@pip//:pylint_pkg",
@alexeaglealexeagleJan 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it just be @pip//pylint ? That's the nicest syntax users would enjoy most.

(we'd generate a external/pip/pylint/BUILD.bazel file with appropriate aliases)
@aignasaignasJan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use this and would be willing to implement this if this approach was agreed universally. @rickeylev, any opinions here?
@aignasaignasJan 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle, what do you think about the inclusion of the user friendly aliases?
alexeagle
alexeagle
reviewed
Jan 11, 2023
View reviewed changes
@alexeaglealexeagle
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
@groodt
groodt
commented
Jan 11, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
What if gazelle was changed to use the requirement function?
That's how it works in Java:
https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD#L7
I am working on a PR that refactors the external package artifact macros. Which would make things a lot simpler for both bzlmod and general maintenance of the rules. The artifact macros in rules_jvm_external work quite differently to the present repository rules in rules_python. The overuse of repository rules in rules_python is a bit of legacy tech-debt which I'm hoping to clean up.
@aignas
aignas
commented
Jan 18, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@groodt, should we wait for the #989 to be done before we think about this again?
I personally found that something like @pip//pylint would be much nicer than artifact("pylint") because I can easily query the external targets as there are fewer layers of abstraction here. Any opinions from others?
@aignasaignas
mentioned this pull request
Jan 27, 2023
 Closed

12 tasks
aignasand others
added 2 commits
January 27, 2023 12:23
@aignas
feat: Store alias labels in requirements arrays if using bzlmod
fbe64c0
This changes the label strings that the users would get when loading the
`all_requirements` and `all_whl_requirements` from the generated
`requirements.bzl`. Previous labels were not really useable under
bzlmod, because they would not be visible to the consumer.
Work towards bazel-contrib#965
@aignas
feat!: generate user friendly aliases for everyone
bddd80f
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.
I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.
Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@aignasaignas
changed the title
feat(pip_parse): Store alias labels in requirements arrays if using bzlmodfeat(pip_parse)!: use user friendly aliases to pip repos in requirements arraysJan 27, 2023
@aignas
aignas
commented
Feb 13, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
This is getting stale, so I'll close this in favour of something else in the somewhat near future. It was also a breaking change, and we should avoid making them.
@aignasaignas
closed this
Feb 13, 2023
@aignas
aignas
deleted the

gazelle-bzlmod-1

branch
February 13, 2023 05:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexeaglealexeaglealexeagle left review comments
@hrfullerhrfullerAwaiting requested review from hrfuller
@rickeylevrickeylevAwaiting requested review from rickeylevrickeylev is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aignas@groodt@alexeagle