Uh oh!
There was an error while loading. Please reload this page.
Add includes option to ruby_bundle rule for per-gem load path customization - #102
Conversation
mmizutani
commented
Jul 8, 2021
Thank you for updating the CI settings. I will look into the errors: https://app.circleci.com/pipelines/github/bazelruby/rules_ruby/307/workflows/bdd3ad88-e478-4e37-8029-b16e3ef1b38e/jobs/1073 |
kigster
commented
Jul 8, 2021
@mmizutani Keep in mind that ruby version went up to 3.0.1 across the board. Perhaps you might want to update it as well, so that on CI we don't need to build a 2.7 interpreter. The 3.0.1 is pulled with the Docker image. |
kigster
commented
Jul 8, 2021
This, once ready, will be the 0.5.1 release. |
kigster
commented
Jul 8, 2021
Let me know if you'd like to pair on figuring out the broken build issues. I am in San Francisco time zone. |
mmizutani
commented
Jul 8, 2021
The tests have now been fixed. Thank you for your advice. |
kigster
commented
Jul 9, 2021
Amazing! |
kigster
left a comment
There was a problem hiding this comment.
LGTM — there are couple of small clarifications, otherwise good to go.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes the gem registration logics to load all of the paths specified in the
require_pathsproperty of gemspecsinstead of loading only the standard, hardcoded path
["lib"].Also, this PR extends
ruby_bundlerule to also acceptincludesoption, which allows us to specify additional library load paths not listed in the gemspecs'require_pathsfor specific rubygems like this:With both
includesandexcludesper-gem options at hand, users ofruby_bundlerule have more granular control over gem load paths, possibly addressing issues #85 , #86 , #97.