repo-review: add README License section

[bborbe]

Repo review at HEAD. Findings counted after dropping generated sources per commands/code-review.md Step 1.

Fixed

README had no ## License section(rule: go-licensing/readme-license-section-required) — LICENSE is present and the source headers reference it, but the README never did.

Found by a fleet-wide check across the 21 repos remaining in this review sweep: all 21 carry a LICENSE, 10 had no README section pointing at it.go-skeleton, the template new services are generated from, has one — so this is drift from an existing correct standard rather than a missing convention.

Also checked, no action needed

• SentryDSN masking — verified across main.goandcmd/*/main.go in all 21 repos. Every declaration already carries display:"length". (An earlier scan in this sweep only looked at root main.go; this one uses find -maxdepth 3 -name main.go, so multi-binary repos are covered.)
• LICENSE presence — present in all 21.

Refuted

The remaining findings fall to the standing triage table (no-package-function-calls, no-bare-error-call, suite-test-file-required, no-testing-t-direct, the counterfeiter pair, slog-not-glog, subject-under-50-chars, changelog/unreleased-entry-required) plus the context-cancellation family, assessed against the narrow form established earlier in this sweep: guard when an iteration starts expensive external work that has not begun yet, or when a long-lived daemon loop is idempotent per entry. None of the loops here qualifies — they iterate already-fetched in-memory collections while the blocking calls take ctx and honour it themselves.

Preconditions

P1 ✅ · P3 ✅ make precommit exit 0. P2 waived where the repo is not dark-factory-initialised — that gate exists so dark-factory prompt approve works in the agent execution phase, and this was a direct edit, so it protects an unused path.

[ben-s-pull-request-reviewer]

Step 4d-sel ADJUDICATE findings:

1. changelog/conventional-prefix-required — The new ## Unreleased bullet starts with docs: which is a valid conventional prefix (feat:, fix:, refactor:, test:, docs:, chore:, perf:). ✅ PASSES — no violation.

2. go-licensing/readme-license-section-required — The diff adds exactly what the rule requires: a ## License H2 section pointing at the root LICENSE file. The existing LICENSE file is confirmed at repo root. ✅ PASSES — no violation.

3. readme/user-facing-not-agent-context — The README content (description + admin links + license) is entirely user-facing. No agent-operational content (build commands, architecture internals, ban lists) is present. ✅ PASSES — no violation.

4. markdown-todo/lowercase-x-for-complete — Neither CHANGELOG.md nor README.md contains any checkbox syntax ([ ] / [x]). Rule is inapplicable to this diff. ✅ N/A.

Skipped (git-commit rules triggered by @commits): cannot evaluate commit messages from the diff alone — the PR title "docs: add a README License section" is itself imperative, but commit-message rules require reading git log output which is out of scope for a diff-only review.

---

PR Review Report

PR:bborbe/agent-task-controller#15 — repo-review: add README License section
Changed files:README.md, CHANGELOG.md
Scope: docs

Must Fix (Critical)

None.

Should Fix (Important)

None.

Nice to Have (Optional)

None.

Notes

• LICENSE file confirmed present at repo root.
• changelog/conventional-prefix-required: The new ## Unreleased bullet correctly uses docs: prefix.
• go-licensing/readme-license-section-required: The new ## License H2 section correctly points to the LICENSE file — exactly what the rule requires.
• readme/user-facing-not-agent-context: README content (project description, admin URLs, license) is entirely user-facing; no agent-operational content introduced.
• precommit skipped (selector mode) — CI covers lint+test.

Selector Mode Traceability

• Candidates: 7 rules matched by Step 4b-i glob filter
• Applicable: 4 rules selected by Step 4c-sel
• Skipped (one line each):
  • git-commit/feature-branch-no-tag → docs-only PR; no feature branch tag applicable
  • git-commit/imperative-mood → cannot evaluate commit message from diff alone
  • git-workflow/never-direct-commit-to-master → docs-only PR; commit is on feature branch going through PR

---

Selector clean — no adjudication needed.

{
"verdict": "approve",
"summary": "Pure documentation PR adding a License section to README.md and a corresponding changelog entry. All applicable judgment rules pass: the License section is correctly formatted, the changelog bullet uses a valid conventional prefix, and the README contains no agent-operational content. No issues found.",
"comments": [],
"concerns_addressed": [
"correctness: License section added to README.md with correct BSD-style reference and link to LICENSE file"
]
}