Skip to content

fix: bump golang base image to 1.26.6 in Dockerfile - #19

Merged
bborbe merged 1 commit into
masterfrom
fix/dockerfile-go-1266
Aug 17, 2026
Merged

fix: bump golang base image to 1.26.6 in Dockerfile#19
bborbe merged 1 commit into
masterfrom
fix/dockerfile-go-1266

Conversation

@bborbe

Copy link
Copy Markdown
Owner

go.mod was bumped to go 1.26.6 but the Dockerfile still pinned golang:1.26.5, making make build fail (GOTOOLCHAIN=local, go.mod requires >= 1.26.6). v0.3.4's image could not be built. Match the other framework repos (agent-task-executor, github-update-go-agent) which already use golang:1.26.6.

go.mod was bumped to go 1.26.6 (v0.3.3, and the v0.81.3 dep bump) but the
Dockerfile still pinned golang:1.26.5, making the image unbuildable
(GOTOOLCHAIN=local + go.mod requires >= 1.26.6). Match the other framework
repos (executor, update-go-agent) which already use golang:1.26.6.

@ben-s-pull-request-reviewerben-s-pull-request-reviewerBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 4c-sel CLASSIFY

The diff only touches Dockerfile. The only judgment rule with a trigger matching Dockerfile is:

  • go-build-args/three-args-required — Dockerfile declares all three args (BUILD_GIT_VERSION, BUILD_GIT_COMMIT, BUILD_DATE). The rule is satisfied.

No other judgment rules have triggers covering Dockerfile. The license-assistant triggers are **/*.go only. All other rules trigger on Go files, which are unchanged.

Step 4d-sel ADJUDICATE

  • go-build-args/three-args-required: satisfied — all three ARG declarations present (lines 3–5 and 15–17).
  • changelog/unreleased-entry-required (mechanical finding): false positive — v0.3.4 is a release PR; the CHANGELOG already has an entry for v0.3.4 at ## v0.3.4. No ## Unreleased needed.

Selector clean — no adjudication needed.


Step 7: Manual Review

  • Dockerfile line 2: golang:1.26.6 is a trusted registry image. The prior version 1.26.5 was subject to CVEs GO-2026-5026, GO-2026-5972, GO-2026-6090, GO-2026-6218, all patched in 1.26.6. The go.mod already declares go 1.26.6, confirming the module was already updated to match. No issues.

Step 5: Consolidated Report

Must Fix (Critical): None.

Should Fix (Important): None.

Nice to Have (Optional): None.

Notes:

  • Precommit skipped (selector mode) — CI covers lint+test.
  • The changelog/unreleased-entry-required mechanical finding is a known false positive for this PR: it is the release PR for v0.3.4, and the CHANGELOG already carries that version header.

Traceability (selector mode):

  • Candidates: 1 rule matched by glob filter
  • Applicable: 1 (go-build-args/three-args-required)
  • Skipped: none

{
"verdict": "approve",
"summary": "PR bumps the golang base image from 1.26.5 to 1.26.6, aligning with the already-updated go.mod go version. Dockerfile retains all three required build args (BUILD_GIT_VERSION, BUILD_GIT_COMMIT, BUILD_DATE). The changelog mechanical finding is a false positive — this is the v0.3.4 release PR, not a pre-release change.",
"comments": [],
"concerns_addressed": [
"security: golang:1.26.6 image is official/trusted — patches GO-2026-5026/5972/6090/6218 — addressed by Dockerfile line 2",
"correctness: go.mod already declares go 1.26.6, matching the Dockerfile FROM — addressed in go.mod line 3"
]
}

@bborbe
bborbe merged commit 76f4d12 into masterAug 17, 2026
1 check passed
@bborbe
bborbe deleted the fix/dockerfile-go-1266 branch August 17, 2026 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@bborbe