fix: bump golang base image to 1.26.6 in Dockerfile - #19
Merged
Conversation
go.mod was bumped to go 1.26.6 (v0.3.3, and the v0.81.3 dep bump) but the Dockerfile still pinned golang:1.26.5, making the image unbuildable (GOTOOLCHAIN=local + go.mod requires >= 1.26.6). Match the other framework repos (executor, update-go-agent) which already use golang:1.26.6.
There was a problem hiding this comment.
Step 4c-sel CLASSIFY
The diff only touches Dockerfile. The only judgment rule with a trigger matching Dockerfile is:
go-build-args/three-args-required— Dockerfile declares all three args (BUILD_GIT_VERSION, BUILD_GIT_COMMIT, BUILD_DATE). The rule is satisfied.
No other judgment rules have triggers covering Dockerfile. The license-assistant triggers are **/*.go only. All other rules trigger on Go files, which are unchanged.
Step 4d-sel ADJUDICATE
go-build-args/three-args-required: satisfied — all threeARGdeclarations present (lines 3–5 and 15–17).changelog/unreleased-entry-required(mechanical finding): false positive — v0.3.4 is a release PR; the CHANGELOG already has an entry for v0.3.4 at## v0.3.4. No## Unreleasedneeded.
Selector clean — no adjudication needed.
Step 7: Manual Review
Dockerfileline 2:golang:1.26.6is a trusted registry image. The prior version1.26.5was subject to CVEs GO-2026-5026, GO-2026-5972, GO-2026-6090, GO-2026-6218, all patched in 1.26.6. Thego.modalready declaresgo 1.26.6, confirming the module was already updated to match. No issues.
Step 5: Consolidated Report
Must Fix (Critical): None.
Should Fix (Important): None.
Nice to Have (Optional): None.
Notes:
- Precommit skipped (selector mode) — CI covers lint+test.
- The
changelog/unreleased-entry-requiredmechanical finding is a known false positive for this PR: it is the release PR for v0.3.4, and the CHANGELOG already carries that version header.
Traceability (selector mode):
- Candidates: 1 rule matched by glob filter
- Applicable: 1 (
go-build-args/three-args-required) - Skipped: none
{
"verdict": "approve",
"summary": "PR bumps the golang base image from 1.26.5 to 1.26.6, aligning with the already-updated go.mod go version. Dockerfile retains all three required build args (BUILD_GIT_VERSION, BUILD_GIT_COMMIT, BUILD_DATE). The changelog mechanical finding is a false positive — this is the v0.3.4 release PR, not a pre-release change.",
"comments": [],
"concerns_addressed": [
"security: golang:1.26.6 image is official/trusted — patches GO-2026-5026/5972/6090/6218 — addressed by Dockerfile line 2",
"correctness: go.mod already declares go 1.26.6, matching the Dockerfile FROM — addressed in go.mod line 3"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod was bumped to
go 1.26.6but the Dockerfile still pinnedgolang:1.26.5, makingmake buildfail (GOTOOLCHAIN=local, go.mod requires >= 1.26.6). v0.3.4's image could not be built. Match the other framework repos (agent-task-executor, github-update-go-agent) which already usegolang:1.26.6.