fix: regenerate rules/index.json with @commits trigger - #109
Merged
Conversation
…ct-commit-to-master
There was a problem hiding this comment.
PR Review Report
No changes to review — the diff is clean and correct.
Verdict: approve
This PR adds the missing trigger: ["@commits"] field to git-workflow/never-direct-commit-to-master in rules/index.json, which is exactly the right fix. The CHANGELOG entry uses conventional commit format. The JSON is valid. No issues found.
{
"verdict": "approve",
"summary": "Clean bugfix: adds the missing @commits trigger to git-workflow/never-direct-commit-to-master so make precommit (check-index) no longer fails. CHANGELOG entry follows conventions. No issues found.",
"comments": [],
"concerns_addressed": []
}Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate
rules/index.jsonviamake build-index. The committed index was missing thetrigger: ["@commits"]entry forgit-workflow/never-direct-commit-to-master(the**Trigger**: @commitsline is in docs since 7a8c11d), somake precommit->check-indexfailed on every push.make check-indexnow passes.