docs: trim agent-command-development-guide to rules-only (1750 → 347 lines)

[bborbe]

Summary

Trims `docs/agent-command-development-guide.md` from 1750 → 347 lines (-80%). Comprehensive reference moves to maintainer's Obsidian KB; coding/docs/ keeps only the enforceable rules used by `coding:agent-auditor` + `coding:slash-command-auditor`.

Mirrors the trim shape from PR #6 (prometheus) + PR #7 (testing).

Why

User confirmed Obsidian-comprehensive / coding-compact architecture in [[Refactor coding pr-review to doc-driven rules pipeline]]. This guide was the largest unstructured doc remaining in coding/ — bootstrap pass (Phase 3) needs tractable source, 1750 lines isn't tractable.

Rules pre-canonicalized

The compact version writes 7 rules in canonical `### RULE` form ready for the bootstrap walker:

• `agent-cmd/command-thin` (MUST) — commands ≤ 100 lines
• `agent-cmd/no-user-prompts` (MUST) — no /tmp/ writes, no permission prompts during normal execution
• `agent-cmd/scripts-in-claude-dir` (MUST) — scripts pre-created in ~/.claude/scripts/ or skill-local scripts/
• `agent-cmd/command-frontmatter` (MUST) — description / allowed-tools / argument-hint contract
• `agent-cmd/agent-frontmatter` (MUST) — name / description / tools
• `agent-cmd/single-source-of-truth` (SHOULD)
• `agent-cmd/gap-driven-feedback` (SHOULD)

Bootstrap (adding these to `rules/index.json` via the walker) happens in a follow-up PR — kept separate so the trim diff stays reviewable.

Dropped content

• Extensive Why-This-Matters prose
• Multiple duplicate examples per pattern
• Long XML-tag taxonomy with detailed semantics
• Trading-domain examples (`strategy-development-commander`, `backtest/strategy/`, MCP trading tools, '40 Trading/Strategy Documentation Checklist for Commander.md')
• Real-world walk-through with named bborbe strategies
• Setup-and-configuration deep dives

Lessons from PR #6 + #8 applied pre-push

• `grep -nEi "personal/|/users/bborbe|~/Documents/Obsidian"` → clean
• Trading-term grep (`candle|epic|broker|signalstore`) → clean
• No internal contradictions (rule examples don't violate sibling rules)
• Auditor lookups still resolve — file lives at same path, all references in agents/agent-auditor.md + agents/slash-command-auditor.md continue to work

Test plan

• `make precommit` clean
• No personal paths
• No trading-domain terms
• Comprehensive reference exists at `Personal/50 Knowledge Base/Agent and Command Development Reference.md`
• Compact doc carries 7 rule-block-ready sections
• Bot review (run github-pr-watch)

[ben-s-pull-request-reviewer]

Based on my review, here are my findings:

PR Review Summary:

Files Changed:docs/agent-command-development-guide.md (1750 → 347 lines, ~80% trim)

Verification Results:

Concern	Status
7 canonical RULE blocks complete and self-contained	✅ Verified present
Cross-references from agents still resolve	✅ agent-auditor.md and slash-command-auditor.md reference docs/agent-command-development-guide.md correctly
No personal/Obsidian paths remain	✅ Only generic template ~/Documents/workspaces/<plugin>/ in file org section
No trading-domain terms	✅ grep-clean for candle|epic|broker|signalstore|trading

RULE blocks verified:

1. agent-cmd/command-thin (MUST)
2. agent-cmd/no-user-prompts (MUST)
3. agent-cmd/scripts-in-claude-dir (MUST)
4. agent-cmd/single-source-of-truth (SHOULD)
5. agent-cmd/gap-driven-feedback (SHOULD)
6. agent-cmd/command-frontmatter (MUST)
7. agent-cmd/agent-frontmatter (MUST)

---

{
"verdict": "approve",
"summary": "Documentation trim removing verbose prose while preserving all 7 enforceable RULE blocks. No personal paths, trading-domain terms, or cross-reference breakages detected. The trimmed guide maintains all required frontmatter, naming conventions, and quality checklist items.",
"comments": [],
"concerns_addressed": [
"correctness: 7 canonical RULE blocks verified complete and self-contained",
"correctness: Cross-references from agents/agent-auditor.md and agents/slash-command-auditor.md still resolve to docs/agent-command-development-guide.md",
"correctness: Personal/Obsidian paths grep-clean — only generic template path ~/Documents/workspaces/<plugin>/ remains in file organization section",
"tests: Trading domain terms (candle|epic|broker|signalstore|trading) grep-clean confirmed — no residual trading-specific content"
]
}