Skip to content

document the auto-merge arming window in the README - #9

Merged
ben-s-pull-request-reviewer[bot] merged 1 commit into
masterfrom
docs/auto-merge-arming-window
Aug 19, 2026
Merged

document the auto-merge arming window in the README#9
ben-s-pull-request-reviewer[bot] merged 1 commit into
masterfrom
docs/auto-merge-arming-window

Conversation

@bborbe

Copy link
Copy Markdown
Owner

Adds a README section explaining that auto-merge arming uses the GraphQL enablePullRequestAutoMerge mutation (no REST endpoint exists — the plausible-looking PUT returns 404), that it is rejected with UNPROCESSABLE: Pull request is in clean status on an already-mergeable PR, and why a fast-turnaround PR can therefore go unarmed without anything being broken.

Docs only.

This PR also serves as the live end-to-end test of the v0.5.2 arming path: it carries the auto-merge label and is deliberately left without a review trigger, so it stays blocked long enough for the watcher's poll to arm it.

@bborbebborbe added the auto-merge Opts the PR into GitHub-native auto-merge (watcher arms enablePullRequestAutoMerge) label Aug 19, 2026

@ben-s-pull-request-reviewerben-s-pull-request-reviewerBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"verdict": "approve",
"summary": "PR adds a new 'Auto-merge arming window' section to the README explaining the GraphQL-only nature of GitHub's auto-merge, the UNPROCESSABLE rejection for already-mergeable PRs, and the cursor-based polling behavior that gives roughly one arming attempt per PR update. All factual claims were cross-checked against pkg/githubclient.go and found to be accurate. CHANGELOG.md entry correctly reflects the change. No issues found.",
"comments": [],
"concerns_addressed": [
"correctness: README states no REST endpoint exists, confirmed by pkg/githubclient.go:203-205 which explicitly documents that PUT /repos/{owner}/{repo}/pulls/{number}/auto-merge returns 404 Not Found",
"correctness: README states the exact UNPROCESSABLE error message, confirmed by pkg/githubclient.go:213 and the error construction at lines 253-259",
"correctness: README describes cursor-based polling with one arming attempt per PR update, matching the search-based architecture in pkg/githubclient.go:121-169"
]
}

@ben-s-pull-request-reviewer
ben-s-pull-request-reviewerBot merged commit 4f413bc into masterAug 19, 2026
1 check passed
@ben-s-pull-request-reviewer
ben-s-pull-request-reviewerBot deleted the docs/auto-merge-arming-window branch August 19, 2026 13:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-mergeOpts the PR into GitHub-native auto-merge (watcher arms enablePullRequestAutoMerge)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@bborbe