docs: require a feature worktree for the Direct route - #98
Merged
Conversation
There was a problem hiding this comment.
I've reviewed the PR. Here's my consolidated report:
PR Review: docs: require a feature worktree for the Direct route
Verdict: APPROVE
Changes Reviewed
Single file changed: CLAUDE.md (+6 lines)
Manual Review (Documentation)
The PR adds a critical safety note to the "Direct" workflow decision tree (item 1, answering "No" to the CI pipeline question). The added text:
- Explains the "why": Documents the real-world incident (2026-08-20) where concurrent writers caused a docs branch to lose local changes
- Provides actionable guidance: Gives the exact
git worktreecommand sequence to follow - Fits the document style: Matches the existing format (bold callout, code block, explanatory note)
Step 4 Status
- Step 4a (ast-grep funnel): Skipped —
ast-grep-runner.shnot available in allowlist - Step 4c-sel (selector mode):
selector-mode-guide.mdnot accessible — proceeding with manual review - Step 4 skipped entirely: This is a docs-only PR; no Go/Python/JS source files changed
Must Fix (Critical)
None.
Should Fix (Important)
None.
Nice to Have (Optional)
None.
{
"verdict": "approve",
"summary": "Docs-only PR adds a safety note requiring feature worktrees even for the Direct (non-pipeline) route. The change is accurate, well-written, and documents a real incident with actionable git workflow guidance. No issues found.",
"comments": [],
"concerns_addressed": []
}Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CLAUDE.md§ Choosing a Flow routes markdown/config/yaml changes to Direct ("edit by hand, no dark-factory") but never says where that hand edit goes.Observed 2026-08-20: I read that line, took it as authorization, and cut a branch directly in the shared
~/Documents/workspaces/vault-clicheckout. Another agent was active in that same tree onfix/session-close-tag-line-links— its branch switch moved HEAD out from under me and discarded my uncommitted edits. Recovery cost a patch/revert/re-create cycle.This repo reliably has concurrent writers: the maintainer bot, dark-factory, and sibling Claude sessions. Four worktrees existed during that session.
Change
One paragraph under the Direct branch: Direct still means a feature worktree, with the
--no-trackinvocation from[[Git Development Guide]]§ Worktrees.--no-trackis included deliberately — omitting it makes the new branch trackorigin/master, sopush/pulltarget master. Hit that too in the same session.Docs only.