You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: I'm now wondering if this should be done automatically from the settings in jpyconfig.properties of the jpy.pythonPrefix parameter.
Yes, that's probably a very good idea, as I cannot imagine a use case where it makes sense to let PYTHONHOME be different from jpy.pythonPrefix. Also to reduce redundancy. But note that jpy.pythonPrefix - as far as I remember - has not been a mandatory parameter. So only set PYTHONHOME from jpy.pythonPrefix, if the latter is given.
Also, is it worth bumping the version number to 0.9.1 for these latest changes I submitted?
Not for our project that uses jpy, at least. It is up to you. I can quickly release a 0.9.1.
EDIT:
If you decide to do so, please use the 0.9.x branch. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #144
Added documentation in install section about setting PYTHONHOME from Java.
NOTE: I'm now wondering if this should be done automatically from the settings in
jpyconfig.propertiesof thejpy.pythonPrefixparameter.Also, is it worth bumping the version number to 0.9.1 for these latest changes I submitted?