Uh oh!
There was an error while loading. Please reload this page.
mirrored from https://www.bouncycastle.org/repositories/bc-rust
- Notifications
You must be signed in to change notification settings - Fork 17
Ensure that all crates are #![no_std] #49
Copy link
Copy link
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedCould be picked up by anyone in the communityCould be picked up by anyone in the communityrefactorThis task is primarily about performing a code refactorThis task is primarily about performing a code refactor
Description
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedCould be picked up by anyone in the communityCould be picked up by anyone in the communityrefactorThis task is primarily about performing a code refactorThis task is primarily about performing a code refactor
Might be a duplicate of #14
The work here is to circle back to the earlier crates:
and add
#![no_std]to the top of theirlib.rs, see what breaks.I suspect the things that will break will be of the flavour:
some of those will be able to convert to
-> [u8; LEN]for some obvious choice of parametrized constantLEN(like the size of the hash function), but some of them might really need to be-> Vec<u8>in which case we should leave them but establish a pattern for guarding them with a cargo feature so that they compile out when building in no_stdSomething like:
or maybe we want all crates to have a feature
"std"as suggested hereand add [features] std = [] (probably default = ["std"]) to Cargo.toml for all crates that use it.