Support for PHP 7.3

[luzat]

Support for PHP 7.3 would be nice. Without checking, most likely there is not much that needs to be changed apart from specifying different requirements in ext_emconf.php and composer.json?

[Konafets]

I just tested it with PHP 7.3. This works out of the box. An analysis with PHP_Codesniffer resulted in zero errors.

$ phpcs --standard=PHPCompatibility -sv --extensions=php --runtime-set testVersion 7.3 typo3conf/ext/sitemap_generator

Registering sniffs in the PHPCompatibility standard... DONE (104 sniffs registered)
Creating file list... DONE (16 files in queue)
Changing into directory typo3conf/ext/sitemap_generator/Classes/Domain/Repository
Processing SitemapRepository.php [PHP => 3622 tokens in 511 lines]... DONE in 1.26 secs (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator/Classes/Domain/Model
Processing UrlEntry.php [PHP => 638 tokens in 142 lines]... DONE in 112ms (0 errors, 0 warnings)
Processing GoogleNewsUrlEntry.php [PHP => 1084 tokens in 237 lines]... DONE in 196ms (0 errors, 0 warnings)
Processing Sitemap.php [PHP => 358 tokens in 72 lines]... DONE in 111ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator/Classes/Controller
Processing SitemapController.php [PHP => 343 tokens in 67 lines]... DONE in 114ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator/Classes/Service
Processing OrderByService.php [PHP => 408 tokens in 55 lines]... DONE in 98ms (0 errors, 0 warnings)
Processing AdditionalWhereService.php [PHP => 191 tokens in 38 lines]... DONE in 43ms (0 errors, 0 warnings)
Processing GoogleSitemapService.php [PHP => 418 tokens in 78 lines]... DONE in 125ms (0 errors, 0 warnings)
Processing PageUrlService.php [PHP => 322 tokens in 57 lines]... DONE in 94ms (0 errors, 0 warnings)
Processing LimitService.php [PHP => 263 tokens in 44 lines]... DONE in 63ms (0 errors, 0 warnings)
Processing FieldValueService.php [PHP => 343 tokens in 66 lines]... DONE in 88ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator/Classes/Command
Processing TaskCommandController.php [PHP => 226 tokens in 41 lines]... DONE in 85ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator
Processing ext_emconf.php [PHP => 143 tokens in 24 lines]... DONE in 11ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator/Configuration/TCA/Overrides
Processing tt_content.php [PHP => 41 tokens in 8 lines]... DONE in 21ms (0 errors, 0 warnings)
Processing pages.php [PHP => 532 tokens in 68 lines]... DONE in 152ms (0 errors, 0 warnings)
Changing into directory typo3conf/ext/sitemap_generator
Processing ext_localconf.php [PHP => 131 tokens in 14 lines]... DONE in 44ms (0 errors, 0 warnings)

I think you can update the composer.json and allow PHP 7.3.

[Konafets]

This ticket can be closed as it was fixed by #57