Import app branch by shahidajmeri786 · Pull Request #243 · beaverbuilder/assistant

shahidajmeri786 · 2020-03-30T14:46:03Z

Added import app.

Verify file format.
Verify file size.
Can import multiple XML files with multiple post imports.
Can able to import post with metadata and categories.

Suggestion:

needs app icon
how can I redirect to apps? I want to redirect to post list after import complete.

Please check for quick view: https://www.screencast.com/t/oMIo0lrtN

fastlinemedia · 2020-04-01T16:49:55Z

Thanks, Shahid!

I did a test import and got this error...

Array to string conversion in /Server/wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsController.php on line 445

I believe that is because wp_upload_dir returns an array but you're using it as a string. Let me know when that's fixed and I'll continue testing.

For your questions...

needs app icon

Brent can get that going when this is a little closer to release.

how can I redirect to apps? I want to redirect to post list after import complete.

All of the main app components get passed the history object. That is a React Router object and can let you navigate to other apps using history.push( '/fl-content' ).

@brentjett can you still get history from Nav.Context as well?

shahidajmeri786 · 2020-04-02T15:16:31Z

Thanks, Shahid!
I did a test import and got this error...
Array to string conversion in /Server/wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsController.php on line 445
I believe that is because wp_upload_dir returns an array but you're using it as a string. Let me know when that's fixed and I'll continue testing.
For your questions...
needs app icon
Brent can get that going when this is a little closer to release.
how can I redirect to apps? I want to redirect to post list after import complete.
All of the main app components get passed the history object. That is a React Router object and can let you navigate to other apps using history.push( '/fl-content' ).
@brentjett can you still get history from Nav.Context as well?

Hi @fastlinemedia ,

Thank you for the test. I checked and updated the string variable into array one. the funny part is my PHP server did not give the error at all :D

I also add the history object and pushed to a list of posts after import complete.

I pushed code so you will check it out for the further test.

fastlinemedia · 2020-04-06T17:18:44Z

Thanks, @shahidajmeri786! It looks like it's working. Only issue I noticed is that it's only importing one post. I exported two pages using the WordPress exporter but only one imports when using the Assistant importer. Can you check that out?

shahidajmeri786 · 2020-04-10T12:19:51Z

Thanks, @shahidajmeri786! It looks like it's working. Only issue I noticed is that it's only importing one post. I exported two pages using the WordPress exporter but only one imports when using the Assistant importer. Can you check that out?

Hi @fastlinemedia ,

Thanks for testing. Multiple import issue fixed. code pushed. can you please check again?

fastlinemedia · 2020-05-12T21:43:38Z

@shahidajmeri786 I did some testing and ran into a few things. I also merged with master so be sure to npm install!

I'm getting an error that says "Sorry, your file is too large." My max upload size should be enough. Here's a link to my export file if you want to try that.
When there's an error it's still redirecting me to the post list. Maybe it should stay in the import app on error.
Can you break out the import logic into its own REST controller? You'll see I already did that for the export logic. The post controller is getting quite large.

One question: does the import app handle importing attachments?

Fixed attachment import Fixed error redirected to post list Break import logic into separate controller.

shahidajmeri786 · 2020-05-15T10:32:12Z

@shahidajmeri786 I did some testing and ran into a few things. I also merged with master so be sure to npm install!
I'm getting an error that says "Sorry, your file is too large." My max upload size should be enough. Here's a link to my export file if you want to try that.
When there's an error it's still redirecting me to the post list. Maybe it should stay in the import app on error.
Can you break out the import logic into its own REST controller? You'll see I already did that for the export logic. The post controller is getting quite large.
One question: does the import app handle importing attachments?

Fixed Large size upload issue.
Fixed attachment import
Fixed error redirected to post list
Break import logic into a separate controller.

One question: does the import app handle importing attachments?
Answer: Yes now can able to import attachments too

…assistant into import-app-branch

fastlinemedia · 2020-05-25T18:10:09Z

Thanks, @shahidajmeri786! However, I'm getting an error when trying to import this file...

https://share.getcloudapp.com/04uP4KW4

There's nothing in the PHP error log, but the console is showing this...

POST http://localhost/wordpress/wp-json/fl-assistant/v1/posts/import net::ERR_EMPTY_RESPONSE

Can you check that out? Also be sure to pull, I merged in master.

…assistant into import-app-branch

shahidajmeri786 · 2020-05-26T10:52:18Z

Hi @fastlinemedia ,

I tested and checked the import is working fine. check here: https://www.screencast.com/t/ahSFrLxL

there is an import message fix. added post type in the message so user know what successfully imported and what failed.

Can you please tell me your WordPress version which you tested?

fastlinemedia · 2020-06-01T17:56:31Z

Thanks, @shahidajmeri786! I just pulled and it seems to be working now. Looks like it's coming together! I have some code review notes I'll leave on the PR. Also, I'm seeing a few notices in the PHP error log now. Can you look into those?

[01-Jun-2020 17:54:03 UTC] PHP Notice: Undefined index: DESCRIPTION in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 118
[01-Jun-2020 17:54:03 UTC] PHP Notice: Undefined index: EXCERPT:ENCODED in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 119
[01-Jun-2020 17:54:03 UTC] PHP Notice: Undefined index: CATEGORY in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 181
[01-Jun-2020 17:54:03 UTC] PHP Warning: Illegal string offset 'WP:META_KEY' in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 186
[01-Jun-2020 17:54:03 UTC] PHP Warning: Illegal string offset 'WP:META_VALUE' in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 187
[01-Jun-2020 17:54:03 UTC] PHP Warning: Illegal string offset 'WP:META_KEY' in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 186
[01-Jun-2020 17:54:03 UTC] PHP Warning: Illegal string offset 'WP:META_VALUE' in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 187
[01-Jun-2020 17:54:03 UTC] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /wordpress/wp-content/plugins/assistant-git/backend/src/Controllers/PostsImportController.php on line 193

fastlinemedia

Hey @shahidajmeri786 let me know if you have any questions about this review.

fastlinemedia · 2020-06-01T18:00:32Z

+ return rest_ensure_response(
+ [
+ 'error' => true,
+ 'message' => 'Sorry, only XML files are allowed.',


Can you use WordPress translation functions (e.g __ or sprintf) anywhere there is human readable text? We need to be sure to always do that on the front or backend. There are a number of places that need it in this file.

fastlinemedia · 2020-06-01T18:02:19Z

+
+ } else {
+ $fail_imp_count++;
+ return rest_ensure_response(


Do we really want to cancel the entire import if an attachment fails? It might be better to fail silently for attachments and let the import proceed.

Resolved some php warnings Cleanup codelines which are unused Removed Upload ok as not needed anymore Added WP translate for alert text messages Added Dynamic wp allowed file size Fixed post import failed due to terms and metas

shahidajmeri786 · 2020-06-02T14:22:44Z

Worked on feedbacks:
Resolved some PHP warnings.
Cleanup code lines which are unused
Removed unused variable
Added WP translate for alert text messages
Added Dynamic WP allowed file size
Fixed post-import failed due to terms and meta unset case.

shahidajmeri786and others added 4 commits March 5, 2020 14:45

post import startup
266d608

Fixed import errors in the import app.
f5388ca

changes for app import
ea97b7d

import app branch push
f052829

shahidajmeri786 added 2 commits April 2, 2020 20:30

Fix upload dir path and catgeory import issue.
3b19c3a

added history push after post import to navigate to list pf posts
0bb7b5f

Fixes multiple pages import.
81e1bf3

Merged master into import-app-branch.
56ea59e

Fixed Large size upload issue.
c8200a9
Fixed attachment import Fixed error redirected to post list Break import logic into separate controller.

fastlinemedia added 2 commits May 25, 2020 10:58

Merge branch 'master' into import-app-branch
f4c66c0

Merge branch 'import-app-branch' ofhttps://github.com/beaverbuilder/…
d64c206
…assistant into import-app-branch

shahidajmeri786 added 2 commits May 26, 2020 16:12

fixed post type import message text
9526f38

Merge branch 'import-app-branch' ofhttps://github.com/beaverbuilder/…
a8de435
…assistant into import-app-branch

fastlinemedia requested changes Jun 1, 2020
View reviewed changes

improvement of:
8f827fc
Resolved some php warnings Cleanup codelines which are unused Removed Upload ok as not needed anymore Added WP translate for alert text messages Added Dynamic wp allowed file size Fixed post import failed due to terms and metas

Uh oh!

Conversation

shahidajmeri786 commented Mar 30, 2020

Uh oh!

fastlinemedia commented Apr 1, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahidajmeri786 commented Apr 2, 2020

Uh oh!

fastlinemedia commented Apr 6, 2020

Uh oh!

shahidajmeri786 commented Apr 10, 2020

Uh oh!

fastlinemedia commented May 12, 2020

Uh oh!

shahidajmeri786 commented May 15, 2020

Uh oh!

fastlinemedia commented May 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahidajmeri786 commented May 26, 2020

Uh oh!

fastlinemedia commented Jun 1, 2020

Uh oh!

fastlinemedia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fastlinemediaJun 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fastlinemediaJun 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shahidajmeri786 commented Jun 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fastlinemedia commented Apr 1, 2020•
edited
Loading

fastlinemedia commented May 25, 2020•
edited
Loading