New dynamic - #6
Open
danielobiri wants to merge 2523 commits into
Open
Conversation
Summary: GitHub commits: facebook@16ed597facebook/fb303@8e47de4facebook/fbthrift@a2a6528facebook/proxygen@807d7aafacebook/wangle@363b38cfacebook/watchman@2a6ce93facebookexperimental/edencommon@c2fe9a1facebookexperimental/rust-shed@367f4b1facebookincubator/fizz@eac2c99facebookincubator/katran@f73832efacebook/mvfst@82f1ac2facebookincubator/velox@c337b92facebookresearch/recipes@e37d958pytorch/kineto@ffb0ef0 Reviewed By: zpao fbshipit-source-id: d9deb0752b54ca981942873bb48ff16bb14bf60a
Summary: GitHub commits: facebook@c5b8239facebook/fb303@49bf3dbfacebook/fbthrift@dbe5567facebook/proxygen@b40c90efacebook/wangle@2fabdf4facebook/watchman@474643dfacebookexperimental/rust-shed@709ea63facebookincubator/katran@dfe5976facebook/mvfst@e9af041facebookresearch/recipes@88263edmeta-pytorch/multipy@ea75273 Reviewed By: zpao fbshipit-source-id: 16a2940debc1db948de0d79bbb5766b4ab7ec794
Summary: GitHub commits: facebook@012b35bfacebook/fb303@972f077facebook/fbthrift@122f0ccfacebook/proxygen@b3117defacebook/watchman@264f9fefacebookexperimental/rust-shed@325f3c6pytorch/kineto@2f8fa40 Reviewed By: zpao fbshipit-source-id: ae0a5e69cc8923462352f092cb9be2a4e6a4db67
Summary: GitHub commits: facebook@e2e2e00facebook/fb303@bf47b75facebook/fbthrift@3b79333facebook/watchman@27791ccfacebookexperimental/rust-shed@c78af95 Reviewed By: zpao fbshipit-source-id: 9926940a6375d6cdd7770b19673c9f80c86bd560
Summary: GitHub commits: facebook@8118866facebook/fb303@63e5773facebook/fbthrift@c127159facebook/watchman@dce5c01facebookexperimental/rust-shed@88af8c8 Reviewed By: zpao fbshipit-source-id: 7ca490b118c72dc4642edcd294ed384ecb862e13
Summary: GitHub commits: facebook/fbthrift@e795837 Reviewed By: zpao fbshipit-source-id: 5596f3b4d27c514c15c615f83d471a66a80844de
Summary: GitHub commits: facebook@160f46bfacebook/fb303@674a456facebook/fbthrift@fc1ee4cfacebook/rocksdb@d95e376facebook/watchman@bfb58fefacebookexperimental/rust-shed@9631cbbfacebook/mvfst@feb1e8e Reviewed By: zpao fbshipit-source-id: b11da364bdb86448423ba12aeb429df55cd30c27
Summary: GitHub commits: facebook@36f109afacebook/fb303@a046f96facebook/fbthrift@5d76023facebook/proxygen@41e050bfacebook/watchman@329b541facebookexperimental/rust-shed@b90f48c Reviewed By: zpao fbshipit-source-id: 4b2c32b28482fdc69c7e49ee2430c7a658599253
Summary: GitHub commits: facebook/fbthrift@1e2c611facebookarchive/profilo@befd6ae Reviewed By: zpao fbshipit-source-id: 1e6d60daa672ac5213510fe0d99f7ed071c85001
Summary: GitHub commits: facebook/fbthrift@a3fe0f1 Reviewed By: zpao fbshipit-source-id: 207d5e36e99a8b686a444a38a88449327f717036
Summary: GitHub commits: facebook@d994bc1facebook/fb303@c04327afacebook/fbthrift@dcc6674facebook/watchman@e7869adfacebookexperimental/rust-shed@6d9c49ffacebookincubator/velox@1f0dc95 Reviewed By: zpao fbshipit-source-id: edb34b9ef6a1c0af4392ccecdba6be3bd462f99f
Summary: GitHub commits: facebook/fbthrift@35478e7facebook/litho@20d1c9e Reviewed By: zpao fbshipit-source-id: 4046d0887f0522916b588b2d0c4274a7710654dc
Summary: GitHub commits: facebook/folly@05b1dc5 Reviewed By: zpao fbshipit-source-id: 5085b6b37522dac4142059011f3f4254653932fd
Summary: GitHub commits: facebook@08054c8facebook/fb303@bf159dafacebook/fbthrift@290f43bfacebook/litho@ac158d6facebook/proxygen@11ff78dfacebook/wangle@df294f1facebook/watchman@afeb49bfacebookexperimental/edencommon@3e527f6facebookincubator/fizz@77e51effacebookincubator/katran@6df825efacebook/mvfst@aad0f6ffacebookincubator/velox@456c9a6 Reviewed By: zpao fbshipit-source-id: 4a2618ddb759ce7dffd360cceff870d9c297d295
Summary: GitHub commits: facebook@bce01e5facebook/fb303@9f5ad73facebook/fbthrift@57e24e5facebook/proxygen@d119f4afacebook/wangle@7ce175dfacebook/watchman@59cf01cfacebookexperimental/rust-shed@54233a4facebookincubator/katran@b335476facebook/mvfst@896bd82 Reviewed By: zpao fbshipit-source-id: bd9532c15227eb90cac4b5f968ec800edd459d7e
Summary: GitHub commits: facebook@ad5a8e7facebook/fb303@4fc46a7facebook/fbthrift@f9c7386facebook/folly@fc64f53facebook/proxygen@a76ac01facebook/rocksdb@7fbee01facebook/watchman@e87a3aefacebookexperimental/rust-shed@506a4b3 Reviewed By: zpao fbshipit-source-id: 60736f4a28b6d2229fe90d2d68ea36ce06d9db59
Summary: GitHub commits: facebook@fea7fc6facebook/fb303@5aabf71facebook/fbthrift@9b08bbefacebook/litho@547f85cfacebook/proxygen@3b83409facebook/wangle@ec838b4facebook/watchman@c79a5defacebookexperimental/edencommon@48ac869facebookexperimental/rust-shed@90db07cfacebookincubator/fizz@802f22ffacebookincubator/katran@bd08dd3facebook/mvfst@543905cfacebookincubator/velox@71805df Reviewed By: zpao fbshipit-source-id: 059ddb991750f414ce7d994140faf9c94350ba31
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 becsedi#2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 becsedi#3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 becsedi#4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
Summary: GitHub commits: facebook@fa5fa64facebook/fb303@88072a5facebook/fbthrift@357c416facebook/folly@0485ce6facebook/mcrouter@47b7acdfacebook/proxygen@016e32cfacebook/rocksdb@418b36afacebook/wangle@b2db096facebook/watchman@883b0aefacebookexperimental/edencommon@999e2f1facebookexperimental/rust-shed@742c4d0facebookincubator/fizz@b7e72dbfacebookincubator/katran@b3290fefacebook/mvfst@0cf312dfacebookincubator/velox@708435bfacebookresearch/beanmachine@0584abafacebookresearch/multimodal@7069b83pytorch/FBGEMM@6f1bef4 Reviewed By: zpao fbshipit-source-id: f435d630dd1de382901c8a3f67996f37f428d5f9
Summary: GitHub commits: facebook@128f5f7facebook/fb303@d98aef7facebook/fbthrift@cedda79facebook/folly@3a67b58facebook/proxygen@5d10b9afacebook/wangle@48603affacebook/watchman@f86696ffacebookexperimental/edencommon@7d67773facebookexperimental/rust-shed@b45bc82facebookincubator/fizz@9f6d617facebookincubator/katran@8e66accfacebook/mvfst@8507e7afacebookincubator/velox@9d390defacebookresearch/beanmachine@3e446cf Reviewed By: zpao fbshipit-source-id: cb4222941967002be20673445933d7e07e272a45
Summary: GitHub commits: facebook@ce60f7cfacebook/fb303@0e5f81ffacebook/fbthrift@7feb30bfacebook/mcrouter@b81aa1dfacebook/proxygen@8fbe9a3facebook/rocksdb@3f57d84facebook/squangle@49d7615facebook/wangle@9e8a662facebook/watchman@6b17beffacebookexperimental/edencommon@7234916facebookexperimental/rust-shed@d5388cbfacebookincubator/fizz@b29e0e2facebookincubator/katran@d319a0bfacebook/mvfst@0ae7902facebookincubator/velox@7638b3cfacebookresearch/multimodal@f0eddf2 Reviewed By: zpao fbshipit-source-id: 453b925ba34a1adff66c8b98a7e8c224fe5ca66a
Summary: GitHub commits: facebook@c4f5b84facebook/fb303@3d5edd7facebook/fbthrift@224b93ffacebook/proxygen@b771ed5facebook/wangle@d83df24facebook/watchman@6f9476afacebookexperimental/rust-shed@72fde0cfacebookincubator/katran@495a8d4facebook/mvfst@f149966facebookresearch/FLSim@d504076facebookresearch/recipes@051be7c Reviewed By: zpao fbshipit-source-id: 5134d65177324797bfc3ffd94881eee3d23ab624
Summary: GitHub commits: facebook@ba3ccf5facebook/fb303@36beb03facebook/fbthrift@5d2051cfacebook/folly@41c3055facebook/proxygen@e74f7e4facebook/rocksdb@d9e71fbfacebook/watchman@6059bb4facebookexperimental/rust-shed@947798dfacebookincubator/fizz@1d5eaf7facebookincubator/velox@ce230a6facebookresearch/beanmachine@9c751ed Reviewed By: zpao fbshipit-source-id: 79c1fbb73f30419cca8be1995e2274bcfcc9e76f
Summary: GitHub commits: facebook@6415a20facebook/fb303@4b25de9facebook/fbthrift@1848840facebook/proxygen@24907f6facebook/wangle@bd31953facebook/watchman@b886057facebookexperimental/edencommon@e92a6ccfacebookexperimental/rust-shed@b356529facebookincubator/fizz@a71dfbafacebookincubator/katran@20b60fbfacebook/mvfst@cf8601bfacebookincubator/velox@8bd3b7c Reviewed By: zpao fbshipit-source-id: 3b8b404e1f5691d69f9013b77ea3233213eb6db7
Summary: GitHub commits: facebook@39acab4facebook/fb303@3234dc3facebook/fbthrift@999834ffacebook/proxygen@cfc18ebfacebook/wangle@75b0403facebook/watchman@ea8f12ffacebookexperimental/rust-shed@b2d59d9facebookincubator/katran@6e1042cfacebook/mvfst@07070c3 Reviewed By: zpao fbshipit-source-id: a972af20c1f71403d8bb5fd9bf1811b179c30ce3
Summary: GitHub commits: facebook@837502ffacebook/fb303@b1c3a9afacebook/fbthrift@a78e6fcfacebook/proxygen@3934cf1facebook/watchman@9642146facebookexperimental/rust-shed@7fcc9d9 Reviewed By: zpao fbshipit-source-id: 6869e1865236bbd9d9760aabc86d78506c45981a
Summary: GitHub commits: facebook@6014a00facebook/fb303@80e6a07facebook/fbthrift@4112499facebook/folly@55e9ce2facebook/watchman@848e79efacebookexperimental/rust-shed@1eb8488 Reviewed By: zpao fbshipit-source-id: d60e4648ef714b83cd5266827399291881775550
Summary: GitHub commits: facebook@f74386afacebook/fb303@7ee542bfacebook/fbthrift@c1d009ffacebook/folly@2d2e79dfacebook/proxygen@f55bf37facebook/wangle@5d8666bfacebook/watchman@8491ac9facebookexperimental/edencommon@0ae991dfacebookexperimental/rust-shed@33cb221facebookincubator/fizz@c9c30acfacebookincubator/katran@3ca22f2facebook/mvfst@96bc676facebookincubator/velox@fb245c2 Reviewed By: zpao fbshipit-source-id: 45145b25a9bf6a805df1db0b3d948e90f846ecd3
Summary: GitHub commits: facebook@7eb93a6facebook/fb303@c5a9849facebook/fbthrift@52b8a2cfacebook/proxygen@8394f41facebook/wangle@e525712facebook/watchman@52c7aedfacebookexperimental/edencommon@afbb557facebookexperimental/rust-shed@9678798facebookincubator/fizz@d4eeb9efacebookincubator/katran@19fc9ecfacebook/mvfst@aaa3bc6facebookincubator/velox@fafa339 Reviewed By: zpao fbshipit-source-id: 8ba5e8be321e70ac6e07db9dc23bdb9374f26c06
Summary: GitHub commits: facebook@95cfb64facebook/fb303@2aa965bfacebook/fbthrift@84fd706facebook/folly@b428d98facebook/proxygen@38f43dffacebook/wangle@afb5274facebook/watchman@34d6767facebookexperimental/rust-shed@2ba0a9efacebookincubator/katran@ccbf1fffacebook/mvfst@450f90f Reviewed By: zpao fbshipit-source-id: b20929d6f6224ed54905d3b5d71a1c0f06cc19a8
Initial support of NUMA bindings
The issue was caused by incorrect behaviour of the CacheAllocator<CacheTrait>::tryEvictToNextMemoryTier method in case the evicted item is expired. We cannot simply return a handle to it, but we need to remove it from the access container and MM container.
Fix ReaperSkippingSlabTraversalWhileSlabReleasing test
Fix moveRegularItemWithSync and add tests
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
This reverts commit 033e09e.
This reverts commit 5da310f.
This reverts commit 033e09e.
This reverts commit c8b3a1c.
This reverts commit 27ec479.
This reverts commit 337d25f.
cosmetic changes made after code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.