Skip to content

Intro to GitHub apps - #42

Merged
hiimbex merged 8 commits into
behaviorbot:masterfrom
JasonEtco:intro-to-github-apps
Oct 10, 2018
Merged

Intro to GitHub apps#42
hiimbex merged 8 commits into
behaviorbot:masterfrom
JasonEtco:intro-to-github-apps

Conversation

@JasonEtco

@JasonEtcoJasonEtco commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

Adding some special interactions 🤖

cc @hollenberry

@update-docs

update-docsBot commented Oct 10, 2018

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@welcome

welcomeBot commented Oct 10, 2018

Copy link
Copy Markdown

Thanks so much for opening your first PR here!

hiimbex
hiimbex reviewed Oct 10, 2018
View reviewed changes
Comment threadindex.js Outdated
owner: context.payload.installation.account.login,
repo: NAME,
title: 'Great job installing WIP!',
body: 'Some body'

@hiimbexhiimbexOct 10, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these arcuate?

title: 'Great job installing Request Info!',
body: 'Yay!!'

@JasonEtcoJasonEtcoOct 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - @hollenberry needs to fix 'em

@hollenberryhollenberryOct 10, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonEtco can we still just add an issue comment on the open PR?

@hollenberryhollenberryOct 10, 2018•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, can we set the body to...

'Well done! You successfully installed the request info app.

disclaimer If you use this app in future repos, you won't get a message like this. This is just for Learning Lab!`

Or something similar.

cc: @a-a-ron for feedback

@a-a-rona-a-ronOct 10, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if that works @JasonEtco so we can update this

@hollenberryhollenberry mentioned this pull request Oct 10, 2018
Closed
@JasonEtco

JasonEtco commented Oct 10, 2018

Copy link
Copy Markdown
ContributorAuthor

@hiimbex good to go 🚀

@hiimbex
hiimbex merged commit fab44ce into behaviorbot:masterOct 10, 2018
@welcome

welcomeBot commented Oct 10, 2018

Copy link
Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!

@hiimbex

hiimbex commented Oct 10, 2018

Copy link
Copy Markdown
Member

Thanks yall!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex left review comments
+2 more reviewers
@a-a-rona-a-rona-a-ron left review comments
@hollenberryhollenberryhollenberry approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JasonEtco@hiimbex@a-a-ron@hollenberry