Skip to content

Update sentiment-bot to require Probot v7.2.0 - #29

Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom
shermanhui:update-probot-version
Oct 11, 2018
Merged

Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom
shermanhui:update-probot-version

Conversation

@shermanhui

@shermanhuishermanhui commented Oct 6, 2018

Copy link
Copy Markdown
Contributor

In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.

This PR will

  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot

This is my first time contributing to this project! Please let me know if I'm missing anything :)

@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome

welcomeBot commented Oct 6, 2018

Copy link
Copy Markdown

Thanks so much for opening your first PR here!

@update-docs

update-docsBot commented Oct 6, 2018

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@shermanhuishermanhui changed the title Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex reviewed Oct 10, 2018
View reviewed changes

@hiimbexhiimbex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?

Comment threadtest/index.js Outdated
// PERSPECTIVE_API_KEY must be set
process.env.PERSPECTIVE_API_KEY = 'mock-key'
const robot = createRobot()
const robot = new Application()

@hiimbexhiimbexOct 10, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?

@shermanhuishermanhuiOct 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!

@hiimbexhiimbexOct 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !

@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex merged commit 5b5a6df into behaviorbot:masterOct 11, 2018
@welcome

welcomeBot commented Oct 11, 2018

Copy link
Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Update sentiment-bot to require Probot v7.2.0 by shermanhui · Pull Request #29 · behaviorbot/sentiment-bot · GitHub
Skip to content
Update sentiment-bot to require Probot v7.2.0 - #29
Merged
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Oct 11, 2018
Merged
Update sentiment-bot to require Probot v7.2.0#29
hiimbex merged 3 commits into
behaviorbot:masterfrom 
shermanhui:update-probot-version
Conversation
@shermanhui
@shermanhuishermanhui
commented
Oct 6, 2018

Copy link


Copy Markdown

Contributor
In the spirit of participating for Hacktoberfest, I'm making a PR to help out with this Updating Probot issue in welcome opened by @hiimbex.
This PR will
  • update the package.json to require Probot v7.2.0 or higher
  • update tests and mock payload to reflect changes in the new major version of Probot
This is my first time contributing to this project! Please let me know if I'm missing anything :)
@shermanhui
Update package.json to require probot v7.20 or higher
f0b7ae6
- Update package-lock as well
@shermanhui
Update test file and payload to accommodate changes in probot v.7.2.0
b342071
- Update old reference from createRobot method to the new Application
class that's being loaded and invoke the class before assigning to the
`robot` const.
- Update payload object key from `event` to `name` as `event` is now
deprecated.
@welcome
welcomeBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks so much for opening your first PR here!
@update-docs
update-docsBot
commented
Oct 6, 2018

Copy link


Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
@shermanhuishermanhui
changed the title
Update Probot Version to 7.2.0Update sentiment-bot to require Probot v7.2.0Oct 6, 2018
hiimbex
hiimbex
reviewed
Oct 10, 2018
View reviewed changes
@hiimbexhiimbex
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! 🎃 one more short update - I should've specified in the original issue, but can we update all uses of robot to app?
Comment threadtest/index.js
Outdated

 // PERSPECTIVE_API_KEY must be set
 process.env.PERSPECTIVE_API_KEY = 'mock-key'
 const robot = createRobot()
 const robot = new Application()
@hiimbexhiimbexOct 10, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also changed robot to app here in the tests and in the index.js file?
@shermanhuishermanhuiOct 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure! Please take a look at the latest commit, I'll wait for your review before doing the same for the other apps!
@hiimbexhiimbexOct 11, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great@ Thanks @shui91 !
@shermanhui
Remove instances of robot in favor of app
041fcc6
- As per PR#29, I've removed all references to `robot`
and updated the keyword to be `app`, due to the
update to the probot dependency to v7.2.0
@hiimbex
hiimbex
merged commit 5b5a6df
into
behaviorbot:masterOct 11, 2018
@welcome
welcomeBot
commented
Oct 11, 2018

Copy link


Copy Markdown

Congrats on merging your first pull request here! 🎉 How awesome!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hiimbexhiimbexhiimbex approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@shermanhui@hiimbex