Observe subscription pump task failures - #27
Merged
beiwei30 merged 1 commit intoAug 25, 2026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
beiwei30
deleted the
codex/rust-maintenance-p3-02-task-failure-observability
branch
August 25, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Observe connection-owned subscription event pump tasks through completion so panics and unexpected cancellations cannot be silently discarded. Expected owner teardown remains quiet, while abnormal exits emit one fixed diagnostic through the existing terminal stream error path.
The change centralizes pump registration and ownership for turn, background, and goal-continuation subscriptions, and adds lifecycle coverage for normal EOF, panic, unexpected cancellation, and processor drop.
Verification
cargo fmt --all --check— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo check --workspace— passedcargo test -p orbcode-app-server message_processor— 40 passedcargo test -p orbcode-app-server processor_drop_aborts_active_subscriptions— passedcargo test -p orbcode-app-server— 234 unit tests plus all integration and doc tests passedRUST_TEST_THREADS=1 cargo test --workspace— all workspace and doc tests passedscripts/check-docs.sh— passedscripts/audit-public-surface.sh— passedscripts/audit-brand.sh— passedgit diff --check— passedParallel workspace runs exposed existing load-sensitive startup/timeout flakes in unrelated tests. Each affected exact test passed three consecutive reruns; the full serialized workspace run passed.
Compatibility
compat-fixtures/fixtures/ortui/testdata/changed.scripts/audit-brand.shpasses.scripts/audit-public-surface.shpasses.orbcode-app-server.Notes for the reviewer
Scope follows the checked-in P3-01 inventory: only connection-owned active subscription pumps in
app-server/src/message_processor.rsare changed. Pending request waiters, client transports, core turns, and TUI task families remain deferred and untouched.