Skip to content

Preserve MCP trust settings error sources - #28

Merged
beiwei30 merged 1 commit into
mainfrom
codex/rust-maintenance-p3-03-error-source-redaction
Aug 26, 2026
Merged

Preserve MCP trust settings error sources#28
beiwei30 merged 1 commit into
mainfrom
codex/rust-maintenance-p3-03-error-source-redaction

Conversation

@beiwei30

Copy link
Copy Markdown
Owner

Summary

  • preserve the typed ConfigError source inside the existing McpError::Io boundary when MCP trust settings persistence fails
  • keep the established display text and McpError protocol code stable while proving settings-content and token canaries remain redacted
  • add focused source-chain and serialized app-protocol regression coverage

Testing

  • cargo test -p orbcode-mcp set_server_trust
  • cargo test -p orbcode-app-server mcp_set_trust_settings_error_redacts_protocol_response
  • cargo test -p orbcode-app-server-client
  • cargo test -p orbcode-app-server-transport
  • cargo test -p orbcode-tools
  • cargo test -p orbcode-mcp
  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo check --workspace
  • cargo test --workspace
  • scripts/check-docs.sh
  • scripts/audit-public-surface.sh
  • scripts/audit-brand.sh
  • git diff --check

CopilotAI lite review requested due to automatic review settings August 26, 2026 05:16

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@beiwei30
beiwei30 merged commit bfdb327 into mainAug 26, 2026
2 of 3 checks passed
@beiwei30
beiwei30 deleted the codex/rust-maintenance-p3-03-error-source-redaction branch August 26, 2026 05:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@beiwei30