Preserve MCP trust settings error sources - #28
Merged
beiwei30 merged 1 commit intoAug 26, 2026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
beiwei30
deleted the
codex/rust-maintenance-p3-03-error-source-redaction
branch
August 26, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigErrorsource inside the existingMcpError::Ioboundary when MCP trust settings persistence failsMcpErrorprotocol code stable while proving settings-content and token canaries remain redactedTesting
cargo test -p orbcode-mcp set_server_trustcargo test -p orbcode-app-server mcp_set_trust_settings_error_redacts_protocol_responsecargo test -p orbcode-app-server-clientcargo test -p orbcode-app-server-transportcargo test -p orbcode-toolscargo test -p orbcode-mcpcargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo check --workspacecargo test --workspacescripts/check-docs.shscripts/audit-public-surface.shscripts/audit-brand.shgit diff --check