Harden MCP WebSocket frame length conversions - #29
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Replace lossy MCP WebSocket payload-length casts with checked conversions and typed protocol failures. Incoming peer-controlled lengths retain the 8 MiB limit and are rejected before platform-width conversion or allocation.
Add boundary coverage for 0, 125, 126, 65,535, 65,536, 8 MiB, 8 MiB + 1, and encoded u64::MAX, including a host-independent 32-bit bound proof.
Verification
Passed:
The focused cast_possible_truncation audit no longer reports the three approved WebSocket conversions. Existing deferred diagnostics in other owners remain unchanged.
Compatibility
Notes for the reviewer
P3-01 limits this maintenance slice to mcp/src/transport/websocket.rs. OAuth timing, tool buffers, protocol DTO widths, provider conversions, and TUI coordinates remain explicitly deferred.