Merge duplicate TUI overlay match arms - #30
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Completes the P3-05 mechanical Clippy cleanup for the two approved TUI overlay match_same_arms sites without changing cursor or rendering behavior.
Adds a table-driven regression test that covers every OverlayState cursor-style case, including both permission-request editing modes and no active overlay.
Verification
Compatibility
Notes for the reviewer
This is a mechanical cleanup with no intended user-visible TUI behavior change, so no terminal screenshot is included.
During repeated native-toolchain validation, one WebSocket startup test and one 100ms MCP discovery timing test each timed out once under load. Both passed in isolation and in their full test groups, and the final complete scripts/check.sh run passed.