Skip to content

Merge duplicate TUI overlay match arms - #30

Merged
beiwei30 merged 1 commit into
mainfrom
codex/rust-maintenance-p3-05-mechanical
Aug 26, 2026
Merged

Merge duplicate TUI overlay match arms#30
beiwei30 merged 1 commit into
mainfrom
codex/rust-maintenance-p3-05-mechanical

Conversation

@beiwei30

Copy link
Copy Markdown
Owner

What changes

Completes the P3-05 mechanical Clippy cleanup for the two approved TUI overlay match_same_arms sites without changing cursor or rendering behavior.

Adds a table-driven regression test that covers every OverlayState cursor-style case, including both permission-request editing modes and no active overlay.

Verification

  • scripts/check.sh — passed: documentation audit, rustfmt, Clippy, default and no-default-features checks, public API audit, brand audit, workspace tests, and doctests.
  • cargo test -p orbcode-tui overlay_cursor_style — 1 passed.
  • cargo test -p orbcode-tui frame_capture — 58 passed.
  • cargo clippy -p orbcode-tui --lib -- -W clippy::match_same_arms — the two targeted layout warnings are gone; 18 previously inventoried TUI warnings remain unchanged.
  • cargo clippy -p orbcode-tui --all-targets -- -D warnings — passed.
  • cargo clippy --workspace --all-targets -- -D warnings — passed.
  • cargo test --workspace — passed.
  • git diff --check — passed.

Compatibility

  • No golden fixture under compat-fixtures/fixtures/ or tui/testdata/ changed.
  • No TypeScript-CLI compatibility name was renamed; scripts/audit-brand.sh passes.
  • No public API changed; scripts/audit-public-surface.sh passes.
  • Behavioral expectations are covered by a test in orbcode-tui.

Notes for the reviewer

This is a mechanical cleanup with no intended user-visible TUI behavior change, so no terminal screenshot is included.

During repeated native-toolchain validation, one WebSocket startup test and one 100ms MCP discovery timing test each timed out once under load. Both passed in isolation and in their full test groups, and the final complete scripts/check.sh run passed.

CopilotAI lite review requested due to automatic review settings August 26, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@beiwei30
beiwei30 merged commit 746aace into mainAug 26, 2026
2 checks passed
@beiwei30
beiwei30 deleted the codex/rust-maintenance-p3-05-mechanical branch August 26, 2026 07:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@beiwei30