Skip to content

Close Rust maintenance plan with sustainable guardrails - #31

Merged
beiwei30 merged 1 commit into
mainfrom
chore/slice-8-closeout
Aug 26, 2026
Merged

Close Rust maintenance plan with sustainable guardrails#31
beiwei30 merged 1 commit into
mainfrom
chore/slice-8-closeout

Conversation

@beiwei30

Copy link
Copy Markdown
Owner

What changes

Close the bounded Rust maintenance plan with a reproducible before/after report and narrow, non-pedantic guardrails for internal permission strings, raw nested options, and production tokio::spawn owners.

Also replace two load-sensitive fixed-time assumptions in WebSocket and MCP stdio tests with deterministic readiness/event synchronization. Production Rust behavior, public APIs, wire formats, fixtures, snapshots, and goldens are unchanged.

Verification

$ scripts/check.sh
✓ All checks passed. (PTY e2e run separately: scripts/check.sh --pty-e2e)
$ cargo clippy --workspace --all-targets -- -D warnings
Finished `dev` profile successfully
$ python3 scripts/audit-rust-maintenance.py --self-test
Ran 4 tests
OK
$ scripts/audit-rust-maintenance.py
✓ string-typed permission_mode boundaries: 6 reviewed occurrence(s)
✓ raw nested-option boundaries: 11 reviewed occurrence(s)
✓ production tokio::spawn owners: 55 spawn(s) across 35 reviewed owner anchor(s)
$ cargo test -p orbcode-tools skills::loader_tests::bounded_mcp_skill_discovery_timeout_does_not_cancel_stdio_request -- --exact
Passed in 10 consecutive runs
$ scripts/rust-maintenance-report.py # run twice
SHA-256 da48915927bcbed49f19d122de9fb65db4f38171051abf0f80ff10d31376e3fa for both byte-identical outputs

Compatibility

  • No golden fixture under compat-fixtures/fixtures/ or tui/testdata/ changed.
  • No TypeScript-CLI compatibility name was renamed; scripts/audit-brand.sh passes.
  • The public API surface is unchanged; scripts/audit-public-surface.sh passes.
  • The test-only readiness and synchronization changes are covered by their affected crate tests.

Notes for the reviewer

The checked-in allow-list records complete, bounded best-effort, or named deferred lifecycle dispositions for every current production spawn owner. Remaining numeric, mechanical, error-source, API, and representation findings are explicitly deferred in the closeout report; this PR does not claim pedantic zero.

CopilotAI lite review requested due to automatic review settings August 26, 2026 09:57

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@beiwei30
beiwei30 merged commit feac541 into mainAug 26, 2026
5 checks passed
@beiwei30
beiwei30 deleted the chore/slice-8-closeout branch August 26, 2026 10:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@beiwei30