fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(web): stop a sent image message reporting "attachment not found" - #151

Merged
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv
Sep 1, 2026
Merged

fix(web): stop a sent image message reporting "attachment not found"#151
tusharbhardwaj-bk merged 4 commits into
expbkmainfrom
t3code/plovdiv

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bktusharbhardwaj-bk commented Sep 1, 2026

Copy link
Copy Markdown

The problem

Sending a message with an image on bkt3 shows a red banner reading

Attachment 'image.png' cannot be sent: attachment not found (removed or expired).

on a turn that has in fact started and is already running. Reported on bkmain today; the claimed attachment file for that turn is on disk, so the message was delivered and the banner is describing a second, failed dispatch of the same turn.

The cause

Since upstream pingdotgg#8048 the web client uploads an image before sending and references it by a pending-… id, then releases that upload as soon as the server acknowledges the turn (releaseAttachmentUploads).

The fork's durable outbox can put the same queued turn on the wire twice:

  • its replay loop is gated on isLocalSendBusy, which clears the moment the server's projection acknowledgement shows the new user message (hasServerAcknowledgedLocalDispatch) — that lands before the RPC reply removes the queue row;
  • and dispatchPersistedOutboxItem deliberately tolerates a failed local removal, on the recorded assumption that "a failed local deletion leaves a harmless duplicate that the server will deduplicate by commandId".

That assumption held before uploads existed. It does not now: the duplicate is normalized in normalizeDispatchCommandbefore any commandId dedup, finds the pending upload already released, and fails — so a live turn is marked failed and gets a Retry/Edit banner.

The fix

The durable send path (startThreadTurnDurably) now records which turns it has on the wire and which it has delivered, and the replay loop consults that record:

  • in flight → skip, the dispatch that owns the row will remove it;
  • delivered → discard the row rather than skip it, because a row left in place latches the composer as permanently busy via deriveOutboxSendGate;
  • rejected → forgotten, so retry and reconnect replay are unchanged.

The selection is a pure function in the fork-owned outbox module, so the call site inside ChatView.tsx shrinks rather than grows.

Surfaces

  • Web/desktop — fixed here.
  • Mobile — unaffected: it still queues images as inline data urls (toQueuedResendAttachments), so its replays carry their own bytes.
  • Server — unchanged.

Verifying

  • vp test run packages/client-runtime/src/outbox/ — 20 passed, 10 of them new in delivery.test.ts covering in-flight/delivered/rejected, identity and environment scoping, the bounded history, oldest-first ordering, and the legacy rows that omit an identity key.
  • vp run --filter @t3tools/web --filter @t3tools/client-runtime typecheck — clean.
  • apps/mobile/src/state/thread-outbox.test.ts and apps/web/src/components/ChatView.logic.test.ts — unchanged and passing.

No UI was added or restyled, so there are no before/after images: the visible change is that a banner stops appearing.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

tusharbhardwaj-bkand others added 4 commits August 29, 2026 15:00
chore: promote expbkmain to bkmain (agent views in chat)
chore: promote expbkmain to bkmain (Mattermost link badge + agent view fixes)
Sending a message with an image on bkt3 could show a red banner reading
"Attachment 'image.png' cannot be sent: attachment not found (removed or
expired)" on a turn that had, in fact, started and was already running.
Since upstream pingdotgg#8048 the web client uploads an image before sending and
references it by a `pending-…` id, then releases that upload as soon as
the server acknowledges the turn. The fork's durable outbox can dispatch
the same queued turn twice: its replay loop is gated on a send state that
clears on the server's *projection* acknowledgement, which lands before
the RPC reply removes the queue row. The second dispatch is normalized
before any commandId dedup, finds the pending upload already released,
and fails — marking a live turn as failed.
The outbox's own comment ("a failed local deletion leaves a harmless
duplicate that the server will deduplicate by commandId") was true before
uploads existed. It is not any more, so the durable send path now records
which turns it has on the wire and which it has delivered. The replay loop
skips the first and discards the second: a row left in place would latch
the composer as permanently busy.
Mobile is unaffected — it still queues images as inline data urls.
Written by Claude Opus 5 in T3 Code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 1, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB15.1 KiB
CodexThread snapshot wire7.2 KiB7.3 KiB
CodexLive turn WebSocket wire6.4 KiB7.8 KiB
CodexLive turn WebSocket decoded55.7 KiB66.4 KiB
CodexLive turn messages1121
ClaudeTotal thread wire13.6 KiB15.1 KiB
ClaudeThread snapshot wire7.2 KiB7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB7.8 KiB
ClaudeLive turn WebSocket decoded56.5 KiB66.4 KiB
ClaudeLive turn messages1121

Baseline: unavailable · PR result: 1a7136b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit cf1aa59 into expbkmainSep 1, 2026
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharbhardwaj-bk