feat: support reordering modifers with a leading comment - #1786
Merged
Conversation
TimothyMakkison
marked this pull request as draft
December 19, 2025 17:59
TimothyMakkisonforce-pushed
the
leading_modifier
branch
from
December 19, 2025 18:25
a6a7809 to
031e37fCompareTimothyMakkison
marked this pull request as ready for review
December 19, 2025 18:25
TimothyMakkison
commented
Dec 19, 2025
ContributorAuthor
Changed the logic for assigning leading trivia because it would always trigger the |
TimothyMakkisonforce-pushed
the
leading_modifier
branch
from
December 19, 2025 18:27
031e37f to
ccaf778CompareTimothyMakkisonforce-pushed
the
leading_modifier
branch
from
December 19, 2025 21:45
ccaf778 to
c9bf50dCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#1784
It might be possible reorder all modiferes with comments and keep this logic. Perhaps this breaks something 🤷