Uh oh!
There was an error while loading. Please reload this page.
fix: Generate parameters to generated client without adding None BNCH-22940 - #77
Conversation
GitOnUp
commented
Jul 8, 2021
William was reviewing this set of changes on the benchling-sdk side for https://github.com/benchling/benchling-sdk/pull/149, but has indicated he's about to be OOO. |
forest-benchling
left a comment
There was a problem hiding this comment.
Is this just so that our switching onto the upstream is more incremental?
GitOnUp
commented
Jul 8, 2021
@forest-benchling yes, and so that we don't continue to accidentally try to call the client functions with None in the interim period before the switch. |
forest-benchling
commented
Jul 8, 2021
@GitOnUp 👍 . Just to clarify, that this is only a matter of type hinting--we're still allowing runtime calls with |
Upstream generates the client this way, and in a parallel benchling-sdk ticket we'll be doing a conversion to UNSET for None parameters in the service layer. Making this change in the fork in the meantime will keep us in a good state.