Uh oh!
There was an error while loading. Please reload this page.
chore: bump node to 24 - #339
Conversation
📝 WalkthroughWalkthroughUpdated Node.js runtime references from v20 to v24 across GitHub Actions workflows, the action manifest ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@action.yml`:
- Line 88: The action runtime was bumped to Node 24 (using: 'node24') but CI and
local settings still pin Node 20, causing version drift; update all workflow
node-version settings and local Node config to 24 by replacing node: 20 /
node-version: 20 entries with 24 in the CI workflows (the
CI/benchmark/ci-results workflows referenced in the PR) and update the .nvmrc
file to "24" so local dev and all workflows match the action runtime; ensure you
change every occurrence (the comment lists multiple occurrences) and run the CI
lint/test to verify no compatibility issues remain.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #339 +/- ##
=======================================
Coverage 89.24% 89.24% =======================================
Files 16 16 Lines 958 958 Branches 205 204 -1 =======================================
Hits 855 855 Misses 99 99 Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktrz
commented
Mar 26, 2026
Thank you @giordano for this PR! |
Uh oh!
There was an error while loading. Please reload this page.
giordano
commented
Mar 26, 2026
Thanks! |
leahneukirchen
commented
Mar 30, 2026
Can you tag a release please? |
ktrz
commented
Mar 31, 2026
released in 1.22.0 |
I'm not familiar with the code of this package, I don't know what else is needed to fix#338, but this is a start.
Summary by CodeRabbit