Skip to content

Use abi3 wheels to support arbitrary Python versions - #15

Merged
benfred merged 9 commits into
benfred:masterfrom
vlaci:abi3-wheels
Apr 28, 2026
Merged

Use abi3 wheels to support arbitrary Python versions#15
benfred merged 9 commits into
benfred:masterfrom
vlaci:abi3-wheels

Conversation

@vlaci

@vlacivlaci commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

As this package does not use any special part of the CPython interface, it can leverage the stable abi, not needing version specific wheels.

This supersedes #11. I also needed to update the github actions to make them work again, so this PR also makes #14 obsolete.

vlaci added 9 commits June 27, 2025 16:05
Rust is available on GitHub hosted runners anyway.
Otherwise build fails with this error:
+ delocate-wheel --require-archs x86_64 -w /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/repaired_wheel -v /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/built_wheel/cpp_demangle-0.1.2-cp38-abi3-macosx_10_12_x86_64.whl
Fixing: /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/built_wheel/cpp_demangle-0.1.2-cp38-abi3-macosx_10_12_x86_64.whl
Traceback (most recent call last):
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/bin/delocate-wheel", line 8, in <module>
sys.exit(main())
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/cmd/delocate_wheel.py", line 116, in main
copied = delocate_wheel(
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/delocating.py", line 1090, in delocate_wheel
out_wheel_fixed = _check_and_update_wheel_name(
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/delocating.py", line 925, in _check_and_update_wheel_name
raise DelocationError(
delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 10.9:
/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/tmp9i_sockf/wheel/cpp_demangle.abi3.so has a minimum target of 10.12
Set the environment variable 'MACOSX_DEPLOYMENT_TARGET=10.12' to update minimum supported macOS for this wheel.
See this build warning:
Warning: cibuildwheel: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect.
@vlaci

Copy link
Copy Markdown
ContributorAuthor

@benfred I don't want to nag you, but it would be awesome if you could take a look at this PR. It should make py-cpp-demangle forward compatible with any new Python release.

@benfredbenfred left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! Changes look good to me.

(sorry for the delay on reviewing)

@benfred
benfred merged commit 5cc1300 into benfred:masterApr 28, 2026
@benfred

Copy link
Copy Markdown
Owner

v0.1.3 is out on pypi now with this change

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vlaci@benfred