fix(workflows): remove unused issues: write and fix permission comments - #12
Merged
Merged
Conversation
…ents Audited changesets/action source — zero octokit.rest.issues.* calls, so `issues: write` is unnecessary. Updated remaining permission comments to accurately attribute each to its consumer (changesets/action vs npm publish).
There was a problem hiding this comment.
Pull request overview
Updates the reusable Changesets release workflow to tighten permissions and improve the accuracy of permission rationale comments.
Changes:
- Removes
issues: writefrom thereleasejob permissions. - Updates permission comments to better reflect which step/action needs each permission.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| id-token: write # for npm provenance verification (changesets/action) | ||
| issues: write # to post issue comments (changesets/action) | ||
| pull-requests: write # to create the pull request (changesets/action) | ||
| attestations: write # to persist npm provenance attestations (npm publish) |
There was a problem hiding this comment.
The attestations: write permission/comment looks incorrect: nothing in this workflow references GitHub Attestations (no actions/attest-* step, and npm publish can’t use GitHub’s attestations API). If no step/action actually creates GitHub attestations, this permission should be removed; otherwise, update the comment to reflect the real consumer and why attestations: write is required.
Suggested change
| attestations: write # to persist npm provenance attestations (npm publish) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues: writefromrelease-changesets.yml— auditedchangesets/actionsource and found zerooctokit.rest.issues.*calls, so this permission is unnecessarychangesets/actionvsnpm publish)Mirrors the fixes applied to
commitlint-configin PR #49.Test plan