[4] Version control change after release note deletion

[johnmunster]

Description

Test for #4 - Created a test that verifies the version number in the admin bar changes accordingly after the current release note has been deleted from the post list screen.

Change Log

• Added a test to delete release note from the release notes post list screen and verify the version number change in the admin bar.
• Changed test:e2e script to include a complete stop of the container and to open Cypress without additional commands needing to be run in the terminal
• Added the ReleaseNoteSeeder file

Steps to test

Checkout to the branch
run npm run test:e2e to start up the docker container and open Cypress
Choose End to End testing
Run release notes version control test

Screenshots/Videos

Successful run of the test - http://bigbite.im/v/wYjf6I

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[g-elwell]

I'm unsure how much value this test adds for us, as it's testing core WP behaviour of deleting a post. We might want to re-think what we're trying to do here.

Based on the assertion against the toolbar version number, perhaps a test to ensure this reflects the most recent release note version number would be more suitable?

[johnmunster]

I thought the same to fair, but I was trying to think of tests to write and its always good to cover CRUD I suppose. The assertion is suppose to be checking against the most recent release so I thought it was OK, but I'll check it again.

[g-elwell]

I thought the same to fair, but I was trying to think of tests to write and its always good to cover CRUD I suppose. The assertion is suppose to be checking against the most recent release so I thought it was OK, but I'll check it again.

Fair point, I wouldn't be dead set against including this if you want to continue with it

[johnmunster]

I'd like to keep it, but it does need some refactoring. I think the assertion isn't great, as I'd like it assert that the version number has changed to the previous release note but at the moment there is no way to check that from the post list screen, so will need revisiting in the future.

[g-elwell]

No worries. If you're planning to refactor please convert the PR to draft and we can re-visit reviewing it when ready.

[johnmunster]

Can I get it merged into main before I refactor it, as I have a feeling some other tests on the main branch might impact how I refactor it.

[johnmunster]

I've changed the test as per our conversation yesterday and resolved the conflict

[g-elwell]

I've changed the test as per our conversation yesterday and resolved the conflict

Cool! I think that since we're actually testing the toolbar version number displays correctly, and not really whether or not you are able to delete a post, that means the PR info should be updated and code-wise the test descriptions and filename will need to change too.

[johnmunster]

Updated necessary details as per previous comment.

[g-elwell]

Looks good to me, test passing locally. Love the new CLI command too!