Replace deprecated ActiveRecord::Base.connection via with_connection - #783
Merged
Conversation
…ion via with_connection
kryali
commented
Feb 6, 2026
ContributorAuthor
hi @binarylogic@brendon can I get a review here? It's been several days, thanks! |
Uh oh!
There was an error while loading. Please reload this page.
brendon
commented
Feb 8, 2026
Collaborator
Hi @kryali, I don't get notified about new PR's. @binarylogic, can you update that for me? I can't access those settings :) This looks all good. I've merged that now. |
brendon
commented
Feb 8, 2026
Collaborator
Released as |
kryali
commented
Feb 8, 2026
via email
ContributorAuthor
Thank you! …On Sun, Feb 8, 2026 at 4:59 PM Brendon Muir ***@***.***> wrote:
*brendon* left a comment (binarylogic/authlogic#783)
<#783 (comment)>
Released as 6.6.1
—
Reply to this email directly, view it on GitHub
<#783 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKWKKQ4HLP4FLARX32ZFT4K6WVXAVCNFSM6AAAAACTXFPR7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNRYGM3TOOJWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails soft-deprecated
ActiveRecord::Base.connectionin favor ofwith_connection, this PR updates authlogic to this new change.relevant activerecord changes: