Conversation
Contributor
Author
|
@flagxor - thinking about this, should it be a git submodule or a pinned hash, ala LLVM? If it's a pinned hash, it would be easier to modulate between downloading binaries or building from source. Are we still planning to pull d8 binaries on the bots? |
Contributor
|
As discussed offline with @ncbray I agree with him and think it's easier to have git hash: I'd rather use the submodule file format and switch from submodule sources to downloaded at will (the tool that gets binaries would just parse that file), but git submodule won't be happy with only a few of the submodules being initialized and the other being downloaded binaries. If we want to switch only some of the dependencies to binary during our workflow then submodules aren't a good fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12