Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Don't let one namespace delete another's server records by subwire · Pull Request #232 · binsync/declib · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion declib/api/server_registry.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ def register_server(info: Dict) -> Path:
payload = dict(info)
payload.setdefault("started_at", time.time())
payload.setdefault("pid", os.getpid())
payload.setdefault("namespace", _namespace_token())
tmp_path = path.with_suffix(".json.tmp")
with open(tmp_path, "w") as f:
json.dump(payload, f, indent=2, default=str)
Expand All@@ -72,6 +73,52 @@ def unregister_server(server_id: str) -> bool:
return False


# A registry directory can be shared by processes that cannot see each other's
# servers -- most easily when several containers bind-mount the same home
# directory, which is exactly how agent harnesses tend to run. Sockets live in
# each container's own /tmp and PIDs are per-namespace, so a sibling's record
# looks dead by both tests, and pruning deletes a perfectly healthy server's
# record. The owner then finds itself missing from the registry.
#
# Stamping each record with the namespace that created it makes "not mine"
# distinguishable from "dead". Foreign records are ignored -- never returned,
# never deleted -- so the owner stays the only writer of its own entries.
def _namespace_token() -> str:
"""Identify the PID/mount namespace this process can observe servers in."""
import socket as _socket

parts = [_socket.gethostname()]
for ns in ("pid", "mnt"):
try:
parts.append(os.readlink(f"/proc/self/ns/{ns}"))
except OSError:
parts.append("?")
return "|".join(parts)


def _probe_socket(socket_path: str, timeout: float = 0.5) -> bool:
"""Whether something is actually accepting connections on `socket_path`.

A socket file on disk proves only that a server once bound there; the file
outlives an unclean death. Connecting is the authoritative test, and it is
the one ida-pro-mcp uses (`probe_instance`) for the same reason.
"""
import socket as _socket

sock = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
sock.settimeout(timeout)
sock.connect(socket_path)
return True
except OSError:
return False
finally:
try:
sock.close()
except OSError:
pass


# A pruned record is the only evidence that a server ever existed. Deleting it
# outright means the *next* command can explain what happened but every command
# after that cannot -- and the command agents run most is `list`, which prunes.
Expand DownExpand Up@@ -160,7 +207,9 @@ def _is_record_live(record: Dict) -> bool:
return False
except Exception:
return False
return True
# Both checks above are proxies: a socket file survives an unclean death,
# and a PID can be reused by an unrelated process. Ask the server directly.
return _probe_socket(socket_path)


def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None) -> List[Dict]:
Expand DownExpand Up@@ -188,6 +237,12 @@ def list_servers(prune_stale: bool = True, pruned: Optional[List[Dict]] = None)
_l.debug("Failed to read server registry file %s: %s", entry, exc)
continue

# A record from another namespace is not ours to judge or delete: its
# socket and pid are meaningless here. Skip it entirely.
record_ns = record.get("namespace")
if record_ns is not None and record_ns != _namespace_token():
continue

if prune_stale and not _is_record_live(record):
if pruned is not None:
pruned.append(record)
Expand Down
118 changes: 118 additions & 0 deletions tests/test_decompiler_cli.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@
"""
import json
import os
import pathlib
import re
import shutil
import subprocess
Expand DownExpand Up@@ -2193,6 +2194,123 @@ def test_read_memory(self):
unittest.main()


class TestRegistryLivenessProbe(unittest.TestCase):
"""A socket file is not proof of life; connecting to it is.

The file outlives an unclean death and a PID can be recycled, so both of
the cheap checks can say "alive" about a server that is gone. ida-pro-mcp
settles this by probing the endpoint; so do we.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_orphaned_socket_file_is_not_alive(self):
"""The exact residue an unclean death leaves behind."""
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock = os.path.join(sockdir, "decompiler.sock")
open(sock, "wb").close() # a file, nothing listening
self.assertFalse(server_registry._is_record_live(
{"id": "x", "socket_path": sock, "pid": os.getpid()}))

def test_a_listening_socket_is_alive(self):
import socket as _socket
import tempfile as _tf
from declib.api import server_registry

with _tf.TemporaryDirectory() as sockdir:
sock_path = os.path.join(sockdir, "decompiler.sock")
srv = _socket.socket(_socket.AF_UNIX, _socket.SOCK_STREAM)
try:
srv.bind(sock_path)
srv.listen(1)
self.assertTrue(server_registry._is_record_live(
{"id": "x", "socket_path": sock_path, "pid": os.getpid()}))
finally:
srv.close()

def test_probe_reports_false_for_a_missing_path(self):
from declib.api import server_registry

self.assertFalse(server_registry._probe_socket("/nonexistent/nope.sock"))


class TestRegistryNamespaceSafety(unittest.TestCase):
"""A shared registry directory must not let one namespace delete another's.

Agent harnesses commonly bind-mount one home directory into several
containers at once. Sockets live in each container's own /tmp and PIDs are
per-namespace, so a sibling's record fails both liveness tests and gets
pruned -- deleting the record of a server that is alive and well. The owner
then cannot find its own server.
"""

def setUp(self):
import tempfile
self._tmp = tempfile.TemporaryDirectory()
os.environ["DECLIB_SERVER_REGISTRY"] = self._tmp.name

def tearDown(self):
os.environ.pop("DECLIB_SERVER_REGISTRY", None)
self._tmp.cleanup()

def test_foreign_records_are_never_deleted(self):
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "sibling01.json"
entry.write_text(_json.dumps({
"id": "sibling01",
"socket_path": "/tmp/declib_server_sibling01/decompiler.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 4242,
"namespace": "some-other-container|pid:[4026531999]|mnt:[4026532999]",
}))
self.assertEqual(server_registry.list_servers(), [],
"a foreign server must not be reported as ours")
self.assertTrue(entry.exists(),
"a foreign record must survive our pruning")

def test_own_records_still_pruned_when_dead(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine01", "socket_path": "/nonexistent/x.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
})
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse((pathlib.Path(self._tmp.name) / "mine01.json").exists())

def test_new_records_carry_a_namespace(self):
from declib.api import server_registry

server_registry.register_server({
"id": "mine02", "socket_path": "/nonexistent/y.sock",
})
import json as _json
rec = _json.loads((pathlib.Path(self._tmp.name) / "mine02.json").read_text())
self.assertTrue(rec.get("namespace"))

def test_legacy_records_without_a_namespace_still_work(self):
"""Records written before this change must not become undeletable."""
import json as _json
from declib.api import server_registry

entry = pathlib.Path(self._tmp.name) / "legacy01.json"
entry.write_text(_json.dumps({
"id": "legacy01", "socket_path": "/nonexistent/z.sock",
"binary_path": "/bin/true", "backend": "ida", "pid": 999999,
}))
self.assertEqual(server_registry.list_servers(), [])
self.assertFalse(entry.exists(), "legacy dead records are still pruned")
class TestGhidraSafeNames(unittest.TestCase):
"""Ghidra rejects characters that filenames are perfectly free to contain.

Expand Down
Loading