Skip to content

🐛 add mandatory permissions for trusted publishing - #8

Merged
enryH merged 2 commits into
mainfrom
7-add-permissions-for-trusted-publishing-to-workflow
Aug 14, 2025
Merged

🐛 add mandatory permissions for trusted publishing#8
enryH merged 2 commits into
mainfrom
7-add-permissions-for-trusted-publishing-to-workflow

Conversation

@angelphanth

Copy link
Copy Markdown

fixes issue #7

@angelphanthangelphanth linked an issue Aug 13, 2025 that may be closed by this pull request
@angelphanth
angelphanth requested a review from enryHAugust 13, 2025 13:54
@angelphanthangelphanth changed the title 🐛 add mandatory permissiones for trusted publishing🐛 add mandatory permissions for trusted publishingAug 13, 2025

@enryHenryH left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for catching it. I obviously forgot to copy it.... I just moved it to the main settings for the publish rule!

@enryH
enryH merged commit b644510 into mainAug 14, 2025
12 checks passed
@enryH
enryH deleted the 7-add-permissions-for-trusted-publishing-to-workflow branch August 14, 2025 12:27
enryH added a commit that referenced this pull request Sep 18, 2025
* 🎨 add flake8 and ruff line length default (to 90 characters)
* 🎨 add formatting of jupyter notebooks per default
* 📝 highlight that also a folder has to be renamed
* 📝 document what extension are used for
* 📝 document debian (ubuntu) package adding which might be needed
* 🎨 use PyPI and GitHub integration instead of secret api token
* 🙈 hide folders creating when locally building the documentation website
* 📝 document desing choices and layout of Python package
* 🎨 add copy button for code blocks per default
* 🎨 small corrections after proof-reading
* 🎨 make name generic and document it. Choose a Licence hint
* 🎨 add design document to Sphinx documentation
* 🎨 add some more common error checking
- set line-length to black default of 88 characters
* Apply suggestions from code review
* 🐛 correct python pkg configuration file
* 🐛 add missing changes for requirments.txt
As noted by Angel using requirements.txt needed one additional change:
- add dependencies to the dynamic field
Add hint to section with dependencies
* 📝 Add hint to GitHub Releases and Source distribution testing
* 🎨 follow Pasquale's advices (.gitignore + unnecessary config)
- add more to .gitignore and link template
- remove line-length configuration as it is already on the default 88 of black formatter
* 📝 add sebastians hints on other ressources
* 🎨 add license key and remove from classifiers as suggested by Sebastian
* 📝 docstring and src layout hints (noted by sebastian)
* 🐛 add missing key to pyproject.toml
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add permissions for trusted publishing to workflow

2 participants

@angelphanth@enryH