Updates for changes in GHC API. Fixes #24. - #28
Conversation
schell
commented
Jan 7, 2014
With this new build I'm sometimes getting "Could not find module x" errors, where x is my own module defined in my project. This problem goes away if I visit the corresponding file in vim. Is this normal? Could my changes have introduced this bug? I'll admit I'm not familiar with the GHC API so my updates could very well be naive at best. They should be vetted. |
bitc
commented
Jan 14, 2014
This is not normal, but it may be a change in GHC API not related to your changes. I plan on waiting for GHC 7.8 to be released (which should happen soon), before looking into this |
schell
commented
Jan 14, 2014
It seems that it had to do with the directory from which I started vim and subsequently, which directory I'm currently looking at in NerdTree. If I start from the directory that contains my Main.hs then everything works fine, so maybe it was just that hdevtools didn't know where my Main.hs was living. |
Updates to GHC API Pretty.showDoc
schell
commented
Feb 13, 2014
There were more changes to the GHC API pertaining to Pretty.showDocWith, which changed to Pretty.showDoc. I rebased, squashed and pushed a fix. |
There was a problem hiding this comment.
showDoc now takes a mode and an Int, but the documentation doesn't say what the Int is for - so I just used 1 as a placeholder.
jstasiak
commented
Apr 6, 2014
+1, this patch allows building hdevtools using GHC 7.8. |
MaxDaten
commented
Apr 11, 2014
ghc-7.8.1 is now released, and this patch is still compatible :) http://www.haskell.org/pipermail/haskell/2014-April/024137.html |
schell
commented
Apr 11, 2014
Also, I've merged these changes with those from @maximkulkin that give cabal support. It seems to be working well for me in vim. |
mitchellwrosen
commented
Apr 16, 2014
would love to see this land |
bitc
commented
Apr 24, 2014
Thanks for this! I'll try to find some time in the next few days to merge and update hackage. One tiny nitpick: Is "707" the proper ifdef guard as you are doing, or should it be 708? What does the community think? |
dmalikov
commented
May 3, 2014
@bitc it will be great to have new 7.8-compatible package |
schell
commented
May 3, 2014
@bitc - the reason I used 707 is because at the time 7.8 wasn't officially out yet. I was using GHC HEAD, which was 7.7. So 707 is valid, but feel free to change it if you think it's confusing! :) |
reem
commented
May 5, 2014
This just compiled cleanly for me on Mavericks with 7.8.2. Thanks a ton. |
darthdeus
commented
May 17, 2014
This works for me too on Mavericks 10.9.3 and GHC 7.8.2. Awesome job! |
mrak
commented
May 28, 2014
Status? |
darthdeus
commented
May 28, 2014
👍 |
Procee
commented
Jun 2, 2014
When will this be merged in? |
gmalkas
commented
Jun 6, 2014
👍 |
tomberek
commented
Jun 8, 2014
For those using Nix, include this patch until a new version is out: |
jstasiak
commented
Jun 15, 2014
Bump |
mitchellwrosen
commented
Jul 14, 2014
@bitc Are you alive? Last we heard you would try to merge this within a "few days", Apr. 24. Would love to get a 7.8-compatible version on Hackage so I don't have to build from source. |
schell
commented
Jul 18, 2014
This patch no longer compiles as of GHC 7.8.3 so I'm closing and have submitted a new one (#33) that includes cabal support by @maximkulkin. |
hdevtools now compiles for me on ghc7.7.