Skip to content

Make RPC console welcome message translation-friendly - #331

Merged
hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:210515-welcome
May 31, 2021
Merged

Make RPC console welcome message translation-friendly#331
hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:210515-welcome

Conversation

@hebasto

@hebastohebasto commented May 15, 2021

Copy link
Copy Markdown
Member

The best practice is do not split a translatable multi-line message into single lines. This helps translators to follow the context.

jarolrod
jarolrod reviewed May 15, 2021
View reviewed changes

@jarolrodjarolrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Comment threadsrc/qt/rpcconsole.cpp Outdated
Comment threadsrc/qt/rpcconsole.cpp
Comment threadsrc/qt/rpcconsole.cpp Outdated
@hebasto

hebasto commented May 15, 2021

Copy link
Copy Markdown
MemberAuthor

Updated b00aaf6 -> a596381 (pr331.01 -> pr331.02, diff):

jarolrod
jarolrod reviewed May 15, 2021
View reviewed changes

@jarolrodjarolrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a596381

@jarolrodjarolrod mentioned this pull request May 19, 2021
Merged
@hebasto

hebasto commented May 19, 2021

Copy link
Copy Markdown
MemberAuthor

Updated a596381 -> 67bef11 (pr331.02 -> pr331.03, diff):

Seeing no reason to use QString optimization tricks as the welcome_message is static now.

@jarolrod

jarolrod commented May 20, 2021

Copy link
Copy Markdown
Contributor

re-ACK 67bef11

@hebasto

hebasto commented May 20, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased 67bef11 -> 0f3d955 (pr331.03 -> pr331.04) due to the conflict with #281.

@jarolrod

jarolrod commented May 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

re-ACK 0f3d955

Screenshots to show that there is no change in the presentation of the welcome message (% new comma for grammar):

MasterPR (0f3d955)
Screen Shot 2021-05-29 at 7 21 35 PMScreen Shot 2021-05-29 at 7 25 23 PM

@hebasto

hebasto commented May 29, 2021

Copy link
Copy Markdown
MemberAuthor

@goums@Talkless Do you mind reviewing this PR?

@hebasto
hebasto requested a review from jonatackMay 29, 2021 12:10
@hebasto
hebasto merged commit aedf71d into bitcoin-core:masterMay 31, 2021
@hebasto
hebasto deleted the 210515-welcome branch May 31, 2021 20:45
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 1, 2021
@hebastojagdeep sidhu
Mergebitcoin-core/gui#331: Make RPC console welcome message translat…
df929d8
…ion-friendly
0f3d955 qt: Make RPC console welcome message translation-friendly (Hennadii Stepanov)
Pull request description:
The best practice is do not split a translatable multi-line message into single lines. This helps translators to follow the context.
ACKs for top commit:
jarolrod:
re-ACK 0f3d955
Tree-SHA512: 30911ff3a972a7787804bb8b27d0b77bfff15939bb478c199261866bfb55d9acd12ab4d44b8b9fc1d4898222cabc4007cc897f9b65728924d121f31e914c44ac
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Mergeaedf71dinto merged_master (Bitcoin PRbitcoin-core/gui#331)
7f55243
@bitcoin-corebitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonatackjonatackAwaiting requested review from jonatack
1 more reviewer
@jarolrodjarolrodjarolrod left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hebasto@jarolrod@DrahtBot