Refactor `TransactionDesc::FormatTxStatus` and ` TransactionStatus` by w0xlt · Pull Request #552 · bitcoin-core/gui

w0xlt · 2022-02-18T19:08:50Z

This PR implements the changes suggested in #538 (comment) .

. remove redundant scope, rename nDepth -> depth, remove unused parameters and add translator comments in TransactionDesc::FormatTxStatus()
. Use member initializers and remove unused field qint64 TransactionStatus::open_for in TransactionStatus.

Closes#538

jonatack

Code review ACK cbf23e4 modulo a couple comments

jonatack

Code review ACK b0ffe4e

hebasto

Approach ACK 0b234f9.

In 0b234f9 "qt: remove redundant scope":

it would be nice to rename s/nDepth/depth/
parameters const interfaces::WalletTx& wtx and int numBlocks are not used, and could be dropped (maybe in a separated commit)
if you feel comfortable doing that, translator comments are always welcome :)

In b0ffe4e "qt: refactor TransactionStatus":

removing of open_for member could be split into a separated commit
bool needsUpdate is still uninitialized
maybe put into commit message something like this " qt, refactor: Use member initializers in TransactionStatus"?

Also could you please, in addition to the link to #538, add actual descriptions of this PR changes to OP, because it goes into a merge commit message.

w0xlt · 2022-02-21T19:40:37Z

@hebasto I have addressed all of your suggestions. Thanks.

promag

Code review ACK b279331

jarolrod

concept ACK

…tus()`

-BEGIN VERIFY SCRIPT- s() { sed -i -e 's/nDepth/depth/g' $(git grep -l 'nDepth' $1); } s src/qt/transactiondesc.cpp -END VERIFY SCRIPT-

…tatus()`

hebasto · 2022-04-12T22:31:24Z

Almost ACK 2c5dbf2 except for 62ab92b "qt, refactor: add translator comments in TransactionDesc::FormatTxStatus()".

If we are adding translator comments, we should also strive to prevent splitting of strings into less meaningful parts.

Suggesting to separate that commit into a dedicated PR, as all of other commits are good to be merged.

@w0xlt Please name this PR in a bit meaningful way because the PR title goes into the project commit history.

w0xlt · 2022-04-13T15:34:30Z

@hebasto the mentioned commit was moved to PR #583.

hebasto

ACK 343f83d, I have reviewed the code and it looks OK, I agree it can be merged.

hebasto · 2022-04-14T16:44:12Z

@jonatack @jarolrod @promag

Mind having another (final?) look?

@MarcoFalke This PR addresses your #538 (comment). Does it look ok?

jarolrod

Code Review ACK 343f83d

Thanks for working on this refactoring. I have reviewed the code and agree that it can be merged.

…` and ` TransactionStatus` 343f83d qt, refactor: Use member initializers in TransactionStatus (w0xlt) 66d58ad qt, refactor: remove unused field `qint64 TransactionStatus::open_for` (w0xlt) ad6aded qt, refactor: remove unused parameters in `TransactionDesc::FormatTxStatus()` (w0xlt) 045f8d0 scripted-diff: rename nDepth -> depth (w0xlt) b1bc143 qt, refactor: remove redundant scope in `TransactionDesc::FormatTxStatus()` (w0xlt) Pull request description: This PR implements the changes suggested in bitcoin-core/gui#538 (comment) . . remove redundant scope, rename `nDepth` -> `depth`, remove unused parameters and add translator comments in `TransactionDesc::FormatTxStatus()` . Use member initializers and remove unused field `qint64 TransactionStatus::open_for` in `TransactionStatus`. Closesbitcoin-core/gui#538 ACKs for top commit: hebasto: ACK 343f83d, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: Code Review ACK bitcoin-core/gui@343f83d Tree-SHA512: cc7333d85b7eb731aa8cdd2d8dfc707341532c93e1b5e3858e8341446cf055ba055b601f9662e8d4602726b1bedf13149c46256a60a0ce1a562f94c9986d945a

8cfb562 qt, refactor: add translator comments in `TransactionDesc::FormatTxStatus()` (w0xlt) Pull request description: This PR adds translator comments to `TransactionDesc::FormatTxStatus` as suggested in #552 (comment) and #552 (comment). ACKs for top commit: hebasto: ACK 8cfb562 Tree-SHA512: 2c44b915e6309508f34fc22bb90e3d88ad32ed82fdb3a395f7c6716941edc1b311991140d28e838ad622a7484ed86aedd25e55674857fec8716d9575aed25fa0

…sc::FormatTxStatus` 8cfb562 qt, refactor: add translator comments in `TransactionDesc::FormatTxStatus()` (w0xlt) Pull request description: This PR adds translator comments to `TransactionDesc::FormatTxStatus` as suggested in bitcoin-core/gui#552 (comment) and bitcoin-core/gui#552 (comment). ACKs for top commit: hebasto: ACK 8cfb562 Tree-SHA512: 2c44b915e6309508f34fc22bb90e3d88ad32ed82fdb3a395f7c6716941edc1b311991140d28e838ad622a7484ed86aedd25e55674857fec8716d9575aed25fa0

jonatack reviewed Feb 19, 2022
View reviewed changes

Comment threadsrc/qt/transactiondesc.cpp Outdated
Comment threadsrc/qt/transactionrecord.h Outdated

w0xlt force-pushed the pr24067-follow-ups branch from cbf23e4 to b0ffe4eCompare February 19, 2022 02:06

jonatack reviewed Feb 20, 2022
View reviewed changes

Comment threadsrc/qt/transactionrecord.h Outdated

hebasto reviewed Feb 20, 2022
View reviewed changes

w0xlt force-pushed the pr24067-follow-ups branch 2 times, most recently from 25fb10d to 064bbdfCompare February 21, 2022 19:17

promag approved these changes Feb 22, 2022
View reviewed changes

Comment threadsrc/qt/transactionrecord.h Outdated

jarolrod reviewed Feb 23, 2022
View reviewed changes

Comment threadsrc/qt/transactiondesc.cpp

w0xlt added 3 commits February 24, 2022 13:47

qt, refactor: remove redundant scope in `TransactionDesc::FormatTxSta…
b1bc143
…tus()`

scripted-diff: rename nDepth -> depth
045f8d0
-BEGIN VERIFY SCRIPT- s() { sed -i -e 's/nDepth/depth/g' $(git grep -l 'nDepth' $1); } s src/qt/transactiondesc.cpp -END VERIFY SCRIPT-

qt, refactor: remove unused parameters in `TransactionDesc::FormatTxS…
ad6aded
…tatus()`

w0xlt force-pushed the pr24067-follow-ups branch 2 times, most recently from 9f5a419 to 2c5dbf2Compare February 24, 2022 17:31

Gemk83 approved these changes Feb 26, 2022
View reviewed changes

hebasto added the Refactoring label Apr 13, 2022

w0xlt changed the title ~~PR24067 follow-ups~~Format TransactionDesc::FormatTxStatus and TransactionStatusApr 13, 2022

w0xlt added 2 commits April 13, 2022 12:24

qt, refactor: remove unused field qint64 TransactionStatus::open_for
66d58ad

qt, refactor: Use member initializers in TransactionStatus
343f83d

w0xlt force-pushed the pr24067-follow-ups branch from 2c5dbf2 to 343f83dCompare April 13, 2022 15:28

w0xlt mentioned this pull request Apr 13, 2022
Add translator comments to TransactionDesc::FormatTxStatus#583
Merged

hebasto changed the title ~~Format TransactionDesc::FormatTxStatus and TransactionStatus~~Refactor TransactionDesc::FormatTxStatus and TransactionStatusApr 13, 2022

hebasto approved these changes Apr 13, 2022
View reviewed changes

jarolrod approved these changes Apr 14, 2022
View reviewed changes

hebasto merged commit 7190de9 into bitcoin-core:masterApr 15, 2022

w0xlt deleted the pr24067-follow-ups branch April 16, 2022 06:26

bitcoin-core locked and limited conversation to collaborators Apr 16, 2023

Uh oh!

Conversation

w0xlt commented Feb 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

w0xlt commented Feb 21, 2022

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented Apr 12, 2022

Uh oh!

w0xlt commented Apr 13, 2022

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Apr 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

w0xlt commented Feb 18, 2022•
edited
Loading

hebasto commented Apr 14, 2022•
edited
Loading