Warn when sending to already-used Bitcoin addresses

[luke-jr]

Entering a used address in the GUI Send tab makes the field turn yellow. Sending to a used address from the GUI prompts with detailed information about prior usage, as well as a note about best practices to avoid address reuse.

Continued from bitcoin/bitcoin#15987 (significantly modified/rewritten - no more bloom filter)

Depends on bitcoin/bitcoin#22693 for non-GUI changes

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	RandyMcMillan, Rspigler

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #555 (Restore Send button when using external signer by Sjors)
• #553 (Change address / amount error background by w0xlt)
• #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)
• #536 (Add address error location to GUI by meshcollider)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[RandyMcMillan]

Concept ACK

[Rspigler]

Concept ACK. Can test when taken out of Draft

[katesalazar]

Great idea, thanks. Hope doesn't break anything.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[hebasto]

Closing this due to lack of activity. Feel free to reopen.