Remove reindex special case from the progress bar label

[maflcko]

The user knows which option they passed to the program, so it seems overly verbose to offer the user feedback whether or not they passed -reindex. Treat it as DISK, like all other cases that are treated as DISK:

• -reindex-chainstate
• -loadblock

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	john-moffett, hebasto
Stale ACK	LarryRuane

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #bitcoin/bitcoin/25781 (Remove almost all blockstorage globals by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[maflcko]

For reference:

• -reindex-chainstate remains unchanged:
  

• -loadblock remains unchanged:
  

• -reindexstage 2 remains unchanged:
  

• -reindexstage 1 (master):
  

• -reindexstage 1 (this pull):
  

[maflcko]

So the only user-visible change should be changing the word "Reindex" to "Index"

[hebasto]

Concept ACK.

As this PR touches code outside the src/qt directory, i.e., src/interfaces/node.h and src/node/interfaces.cpp, should it be moved to the main repo for a broader reviewing?

[maflcko]

It is only changing an interface that the gui uses, so I think it should be fine

[hebasto]

cc @ryanofsky

[LarryRuane]

code-review, tested ACK fa20044

I ran src/qt/bitcoin-qt -noconnect -signet -reindex with and without the PR, and the status message (lower-left corner) for stage 1 was as expected. I didn't try reindex-chainstate, loadblock, or reindex stage 2.

[LarryRuane]

I like this, somehow else following return (or break, continue) doesn't seem right.

[john-moffett]

ACK fa20044

Nit: Maybe remove the one remaining unnecessary enum use for BlockSource?

gui/src/qt/bitcoingui.cpp

Line 1074 in fa20044

enum BlockSource blockSource = clientModel->getBlockSource();

[maflcko]

Thanks, removed and rebased. Should be trivial to re-ACK with git range-diff

[john-moffett]

Re-ACK faff2ba

[hebasto]

ACK faff2ba, I have reviewed the code and it looks OK, I agree it can be merged.

[LarryRuane]

post-merge re-ACK